Fix flaky Ruby nonblocking server tests#3368
Open
kpumuk wants to merge 1 commit intoapache:masterfrom
Open
Conversation
6e82073 to
cb31093
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repeated Ruby suite runs exposed nondeterministic failures in the nonblocking server specs. The failures were caused by incomplete teardown of the Ruby nonblocking server path, which left resources alive across runs and made test ordering matter.
EADDRINUSE-style failures unrelated to the behavior under test.Thread#killtoshutdownplusjoin, withkillonly as a fallback - raw kill made teardown timing-dependent and left cleanup incomplete under repeated suite runs.IOManager#ensure_closed,killand thenjointhe I/O thread before forced cleanup.Thread#killis asynchronous; joining makes forced cleanup synchronous so teardown does not race a still-unwinding I/O thread.ensure_closed. Addresses the situation when the server is torn down abruptly, and sockets remain open and accumulate across runs.[skip ci]anywhere in the commit message to free up build resources.