[ZEPPELIN-6385] Refactor StringsCompleter to use method reference for Comparator#5126
Open
hyunw9 wants to merge 1 commit intoapache:masterfrom
Open
[ZEPPELIN-6385] Refactor StringsCompleter to use method reference for Comparator#5126hyunw9 wants to merge 1 commit intoapache:masterfrom
hyunw9 wants to merge 1 commit intoapache:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
This PR refactors the anonymous Comparator implementation in StringsCompleter to use a method reference (
String::compareToIgnoreCase).The change simplifies the code, improves readability, and aligns the class with modern Java best practices.
What type of PR is it?
Refactoring
Todos
What is the Jira issue?
How should this be tested?
Since the expected behavior remains unchanged, no additional tests are required.
Screenshots (if appropriate)
Questions: