Skip to content

[MINOR] chore(zeppelin-web-angular): refresh lockfile to remediate npm audit findings#5208

Open
jongyoul wants to merge 1 commit intoapache:masterfrom
jongyoul:copilot/fix-npm-audit-issues
Open

[MINOR] chore(zeppelin-web-angular): refresh lockfile to remediate npm audit findings#5208
jongyoul wants to merge 1 commit intoapache:masterfrom
jongyoul:copilot/fix-npm-audit-issues

Conversation

@jongyoul
Copy link
Copy Markdown
Member

@jongyoul jongyoul commented Apr 5, 2026

What is this PR for?

Refresh package-lock.json in zeppelin-web-angular to remediate npm audit findings.
Ran npm audit fix on the latest master to resolve vulnerabilities that can be fixed without breaking changes.

What type of PR is it?

Bug Fix / Improvement

Todos

What is the Jira issue?

How should this be tested?

  • cd zeppelin-web-angular && npm audit should show fewer vulnerabilities

Screenshots (if appropriate)

Questions:

  • Does the license files need to update? No
  • Is there breaking changes for older versions? No
  • Does this needs documentation? No

@jongyoul jongyoul changed the title chore(zeppelin-web-angular): refresh lockfile to remediate npm audit findings [MINOR] chore(zeppelin-web-angular): refresh lockfile to remediate npm audit findings Apr 5, 2026
@jongyoul jongyoul force-pushed the copilot/fix-npm-audit-issues branch from 0e05df7 to d2356a6 Compare April 5, 2026 13:03
…findings

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@jongyoul jongyoul force-pushed the copilot/fix-npm-audit-issues branch 5 times, most recently from 01133e7 to 8e3be8b Compare April 8, 2026 00:21
@jongyoul jongyoul marked this pull request as ready for review April 8, 2026 01:52
Copilot AI review requested due to automatic review settings April 8, 2026 01:52
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates dependency lockfiles to address npm audit findings and includes small e2e/integration test adjustments to improve stability after dependency changes.

Changes:

  • Refreshed package-lock.json files under zeppelin-web-angular/ (including the zeppelin-react project) with multiple dependency version bumps.
  • Added explicit 30s timeouts to several Playwright waitForLoadState('networkidle') calls.
  • Updated Selenium-based integration-test login flow to better handle an already-open login modal and wait for login completion.

Reviewed changes

Copilot reviewed 10 out of 12 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
zeppelin-web-angular/projects/zeppelin-react/package-lock.json Lockfile refresh with updated transitive dependency versions (e.g., brace-expansion, flatted, lodash, picomatch).
zeppelin-web-angular/package-lock.json Main lockfile refresh with numerous transitive updates and additional metadata fields (licenses/engines).
zeppelin-web-angular/e2e/utils.ts Adds explicit timeout to networkidle wait during login flow.
zeppelin-web-angular/e2e/tests/share/note-toc/note-toc.spec.ts Adds explicit timeout to networkidle wait after navigation.
zeppelin-web-angular/e2e/tests/share/note-rename/note-rename.spec.ts Adds explicit timeout to networkidle wait after navigation.
zeppelin-web-angular/e2e/tests/notebook/sidebar/sidebar-functionality.spec.ts Adds explicit timeout to networkidle wait after navigation.
zeppelin-web-angular/e2e/tests/notebook/published/published-paragraph.spec.ts Adds explicit timeout to networkidle wait after navigation.
zeppelin-web-angular/e2e/tests/notebook/paragraph/paragraph-functionality.spec.ts Adds explicit timeout to networkidle wait after navigation.
zeppelin-web-angular/e2e/tests/notebook/main/notebook-container.spec.ts Adds explicit timeout to networkidle wait after navigation.
zeppelin-web-angular/e2e/tests/notebook/keyboard/notebook-keyboard-shortcuts.spec.ts Adds explicit timeout to networkidle wait for a newly opened tab.
zeppelin-web-angular/e2e/tests/notebook/action-bar/action-bar-functionality.spec.ts Adds explicit timeout to networkidle waits in setup and post-action stabilization.
zeppelin-integration/src/test/java/org/apache/zeppelin/AbstractZeppelinIT.java Enhances authentication flow (modal detection, field interactions, post-login wait, backdrop cleanup).
Files not reviewed (1)
  • zeppelin-web-angular/projects/zeppelin-react/package-lock.json: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@jongyoul jongyoul force-pushed the copilot/fix-npm-audit-issues branch 2 times, most recently from 33214d4 to df96b41 Compare April 8, 2026 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants