Fix typo in xkey configuration comment#609
Closed
melany-mai wants to merge 1 commit intoapi-platform:4.3from
Closed
Fix typo in xkey configuration comment#609melany-mai wants to merge 1 commit intoapi-platform:4.3from
melany-mai wants to merge 1 commit intoapi-platform:4.3from
Conversation
paramters -> parameters
Contributor
|
Hi @melany-mai, Thanks for your first PR in this project, you're awesome! But the file you've modified is autogenerated by Symfony. I'm also thinking of removing it from the versionning (there is a debate about it in the Symfony community). Your suggestion might be erased on the next Symfony update. Anyway, don't hesitate to post other suggestions in this project if you find some :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
paramters -> parameters