Conversation
Siegrift
approved these changes
Jan 2, 2026
| expect(checkWithdrawalStatus()).toBe('Withdrawal request is not fulfilled yet'); | ||
|
|
||
| const balanceBefore = await sponsorBalance(); | ||
| // Use retry for balance fetches to handle transient ECONNRESET errors in CI |
Contributor
There was a problem hiding this comment.
This must have caused headaches :/
Contributor
Author
There was a problem hiding this comment.
Oh definitely a massive headache, but I hope now the issue is behind us
| code: 'invalid_format', | ||
| format: 'regex', | ||
| pattern: | ||
| '/^(\\d{4}-[01]\\d-[0-3]\\dT[0-2]\\d:[0-5]\\d:[0-5]\\d\\.\\d+([+-][0-2]\\d:[0-5]\\d|Z))|(\\d{4}-[01]\\d-[0-3]\\dT[0-2]\\d:[0-5]\\d:[0-5]\\d([+-][0-2]\\d:[0-5]\\d|Z))|(\\d{4}-[01]\\d-[0-3]\\dT[0-2]\\d:[0-5]\\d([+-][0-2]\\d:[0-5]\\d|Z))$/', |
Contributor
There was a problem hiding this comment.
Mhh, this looks quite wild.
Contributor
Author
There was a problem hiding this comment.
This is correct because it is how the regex is defined:
However, given how opaque this is, I added a custom error message to the schema regex: Invalid timestamp format: must be ISO and updated the test accordingly in the latest commit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2032.
Steps:
zodandOISyarn update-ois-versionto update the OIS version used in all of the config files