fix: convert img style prop from string to JSX object in overview doc#11
Merged
fix: convert img style prop from string to JSX object in overview doc#11
Conversation
React requires the style prop to be a JavaScript object, not a string. The string style caused Docusaurus SSG to fail with: "The style prop expects a mapping from style properties to values, not a string." Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughUpdated architecture diagram's style attribute from CSS string format to React JSX object format with camelCased CSS property names ( Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
membphis
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<img>tag indocs/introduction/overview.mdused an HTML-style string for thestyleprop (style="..."), which is invalid in JSX/Reactstyleto be a JavaScript object with camelCased properties/aisix/overviewpath with the error:The 'style' prop expects a mapping from style properties to values, not a stringChange
Test plan
pnpm buildin the docs site — the/aisix/overviewSSG error should be gone🤖 Generated with Claude Code
Summary by CodeRabbit
Release Notes