Skip to content

test: add e2e tests for Scrapy spiders running as Apify Actors#788

Merged
vdusek merged 2 commits intomasterfrom
test/e2e-scrapy-spiders
Feb 13, 2026
Merged

test: add e2e tests for Scrapy spiders running as Apify Actors#788
vdusek merged 2 commits intomasterfrom
test/e2e-scrapy-spiders

Conversation

@vdusek
Copy link
Contributor

@vdusek vdusek commented Feb 13, 2026

Summary

Add 5 new e2e tests covering key Scrapy spider types and integration patterns, all using a local HTTP server for reliability. Tests cover basic Spider, CrawlSpider with rules, ItemLoader, cb_kwargs serialization, and custom pipeline merging with apply_apify_settings.

Motivation

  • Better test coverage for Scrapy integration, up until now, we have only 1 E2E test, and that was all.

Issue

Test plan

  • CI passes

Add 5 new e2e tests covering key Scrapy spider types and integration
patterns, all using a local HTTP server for reliability. Tests cover
basic Spider, CrawlSpider with rules, ItemLoader, cb_kwargs
serialization, and custom pipeline merging with apply_apify_settings.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@vdusek vdusek added this to the 134th sprint - Tooling team milestone Feb 13, 2026
@vdusek vdusek requested a review from Pijukatel February 13, 2026 12:28
@vdusek vdusek self-assigned this Feb 13, 2026
@vdusek vdusek added adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team. labels Feb 13, 2026
@github-actions github-actions bot added the tested Temporary label used only programatically for some analytics. label Feb 13, 2026
@codecov
Copy link

codecov bot commented Feb 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.78%. Comparing base (a99b5ff) to head (252f010).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #788      +/-   ##
==========================================
- Coverage   81.86%   81.78%   -0.08%     
==========================================
  Files          46       46              
  Lines        2696     2696              
==========================================
- Hits         2207     2205       -2     
- Misses        489      491       +2     
Flag Coverage Δ
e2e 43.50% <ø> (ø)
integration 55.45% <ø> (ø)
unit 67.95% <ø> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vdusek
Copy link
Contributor Author

vdusek commented Feb 13, 2026

@janbuchar, @Mantisus - not necessary requesting a review, up to you guys, mostly just to keep you informed about the SDK test suite improvements.

@vdusek vdusek merged commit 596821b into master Feb 13, 2026
31 checks passed
@vdusek vdusek deleted the test/e2e-scrapy-spiders branch February 13, 2026 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team. tested Temporary label used only programatically for some analytics.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants