apiserver: replace sample-apiserver and add integration coverage#86
Draft
apiserver: replace sample-apiserver and add integration coverage#86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pkg/apiserver/serverpkg/apiserver/manager.goand storage to the new server path, including configurable bind address/port and local readyz/client handlingpkg/apiserverintegration tests for health, CRUD + sqlite persistence, simple auth, and defaulter/validator hooksReview Guide
pkg/apiserver/server/for the new local apiserver builder/start implementationpkg/apiserver/manager.gofor server boot, auth wiring, and the removal of the sample-apiserver command wrapperpkg/apiserver/storage.gofor the Kine listener/metrics changes needed for repeatable in-process startspkg/apiserver/integration_test.gofor the new coverageDetails
start()by avoiding local variable shadowinglocalhost:8443Tests
go test ./pkg/apiserver -run TestAPIServerIntegration -count=1go test ./pkg/apiserver/... -count=1go build ./cmd/apiserverNotes
system:anonymouswithsystem:unauthenticated, and the integration test asserts that current behaviordbstatwarnings during startup in this environment; that is pre-existing runtime noise and not addressed here