fix(map): handle map values in select_replace match spec for put_newer#16
Merged
fix(map): handle map values in select_replace match spec for put_newer#16
select_replace match spec for put_newer#16Conversation
Maps in ETS match spec bodies were passed through as-is by `ms_literal/1`,
causing "not a valid match specification" errors when values were or
contained maps. Wrap maps with `{:const, map}` so ETS treats them as
opaque literals.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Maps in ETS match spec bodies were passed through as-is by
ms_literal/1, causing "not a valid match specification" errors when values were or contained maps. Wrap maps with{:const, map}so ETS treats them as opaque literals.Note
Low Risk
Low risk bug fix localized to ETS
select_replacematch-spec literal wrapping, with added tests covering nested map/tuple cases.Overview
Fixes
put_newer/5andput_all_newer/3updates when values contain maps by makingms_literal/1wrap maps as{:const, map}so ETS treats them as opaque literals inselect_replacematch spec bodies.Adds regression tests for nested map values and tuple values containing maps, updates the changelog, and bumps the package version to
0.4.1.Reviewed by Cursor Bugbot for commit 517fc7a. Bugbot is set up for automated code reviews on this repo. Configure here.