fall back to simple text output when stdout is not a tty#1392
Open
knQzx wants to merge 2 commits intoapple:mainfrom
Open
fall back to simple text output when stdout is not a tty#1392knQzx wants to merge 2 commits intoapple:mainfrom
knQzx wants to merge 2 commits intoapple:mainfrom
Conversation
Contributor
|
@knQzx Thank you for the PR! Could you please add the commands you tested with, and before/after output, to the PR description? Would it be possible to add an integration test for this? |
Author
|
added before/after output to the description and an integration test for this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
summary
fixes #113
test plan
before (main):
after:
also added
TestCLIProgressAutointegration test covering auto/plain/none modes