Add multi-reference push to ImageStore#661
Open
realrajaryan wants to merge 2 commits intoapple:mainfrom
Open
Conversation
7 tasks
jglogan
reviewed
Apr 7, 2026
jglogan
requested changes
Apr 7, 2026
jglogan
reviewed
Apr 7, 2026
|
|
||
| // Parse all references upfront: validate hosts and avoid re-parsing inside tasks. | ||
| let parsed = try references.map { ref in try Reference.parse(ref) } | ||
| let hosts = Set(parsed.compactMap { $0.resolvedDomain }) |
Contributor
There was a problem hiding this comment.
Are the references canonical; for example, has alpine already been resolved to docker.io/alpine:latest?
If not, this is going to break if I try this with references that are missing hostnames.
This is probably just a documentation matter - the docc for these calls should state what is expected for imageref parameters. But in that case we should probably go first to a hosts List and check that references.count == hosts.count before deduping.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an overload of
ImageStore.pushthat accepts multiple references and shares a singleRegistryClientacross all pushes. Will be used for apple/container#1335