[vminitd]: api for freeze/thaw filesystem operations#685
Draft
saehejkang wants to merge 2 commits intoapple:mainfrom
Draft
[vminitd]: api for freeze/thaw filesystem operations#685saehejkang wants to merge 2 commits intoapple:mainfrom
saehejkang wants to merge 2 commits intoapple:mainfrom
Conversation
Contributor
|
@dcantah wdyt? |
Member
|
Looks good! |
dcantah
reviewed
Apr 15, 2026
Comment on lines
+681
to
+701
| #if os(Linux) | ||
| static let FIFREEZE: UInt = 0xC004_5877 | ||
| let rc: CInt = ioctl(fd, FIFREEZE, 0) | ||
| if rc != 0 { | ||
| throw RPCError(code: .internalError, message: "freeze failed") | ||
| } | ||
| #else | ||
| fatalError("freeze not supported on platform") | ||
| #endif | ||
| } | ||
|
|
||
| private func thawFilesystem(fd: Int32) throws { | ||
| #if os(Linux) | ||
| static let FITHAW: UInt = 0xC004_5878 | ||
| let rc: CInt = ioctl(fd, FITHAW, 0) | ||
| if rc != 0 { | ||
| throw RPCError(code: .internalError, message: "thaw failed") | ||
| } | ||
| #else | ||
| fatalError("thaw not supported on platform") | ||
| #endif |
Member
There was a problem hiding this comment.
I'd leave off the ifdefs, I think we've somewhat accepted that we just care about linux here. I need to go and do a sweep everywhere.
Member
There was a problem hiding this comment.
The rpc itself is already linux specific.
dcantah
reviewed
Apr 15, 2026
Comment on lines
+652
to
+656
| log.debug( | ||
| "filesystemOperation: freezing filesystem", | ||
| metadata: [ | ||
| "path": "\(request.path)" | ||
| ]) |
Member
There was a problem hiding this comment.
I'd get rid of these logs, it doesn't give us any extra info than the one at the top of the method.
dcantah
reviewed
Apr 15, 2026
Comment on lines
+635
to
+644
| throw RPCError(code: .notFound, message: "failed to stat path") | ||
| } | ||
|
|
||
| if (finfo.st_mode & S_IFMT) == S_IFLNK { | ||
| throw RPCError(code: .internalError, message: "path cannot be a symlink") | ||
| } | ||
|
|
||
| fd = open(request.path, O_RDONLY) | ||
| if fd < 0 { | ||
| throw RPCError(code: .internalError, message: "failed to open path") |
Member
There was a problem hiding this comment.
It'd be good in any syscall error return paths to include the errno, it'll be very hard to debug otherwise.
|
|
||
| private func thawFilesystem(fd: Int32) throws { | ||
| #if os(Linux) | ||
| static let FITHAW: UInt = 0xC004_5878 |
Contributor
There was a problem hiding this comment.
Suggestion: static let inside Swift function is not allowed. Linux build will fail.
|
|
||
| private func freezeFilesystem(fd: Int32) throws { | ||
| #if os(Linux) | ||
| static let FIFREEZE: UInt = 0xC004_5877 |
Contributor
There was a problem hiding this comment.
same as the other comment.
| throw RPCError(code: .internalError, message: "path cannot be a symlink") | ||
| } | ||
|
|
||
| fd = open(request.path, O_RDONLY) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addition of
vminitdAPI for freeze/thaw filesystem operationsCloses #660