Merged
Conversation
9 tasks
czechboy0
approved these changes
Feb 25, 2026
|
Thank you, I was just about to open a PR that does exactly this. My reason was different: when decoding JSON, the error's localized description is completely useless ("the data could not be found because it was missing"). Just replacing with Looking forward to the next release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of apple/swift-openapi-generator#868
Refactors
error.localizedDescriptionto"\(error)"to prevent linking Foundation. This will change the error strings as can be seen in the tests. Alternatively, we would split the implementation by a traitFullFoundationSupport. Where that would uselocalizedDescription