Skip to content

Remove localized compares#174

Merged
czechboy0 merged 2 commits intoapple:mainfrom
madsodgaard:localized-compare
Feb 26, 2026
Merged

Remove localized compares#174
czechboy0 merged 2 commits intoapple:mainfrom
madsodgaard:localized-compare

Conversation

@madsodgaard
Copy link
Contributor

Part of apple/swift-openapi-generator#868

Removes usages of localized compares from Foundation and just uses Swift string comparisons.

The logic is covered by the following tests:

Test_URICodingRoundtrip.testRoundtrip
Test_URISerializer.testSerializing
Test_ClientConverterExtensions.test_setOptionalRequestBodyAsURLEncodedForm_codable
Test_ClientConverterExtensions.test_setRequiredRequestBodyAsURLEncodedForm_codable

@czechboy0 czechboy0 enabled auto-merge (squash) February 26, 2026 08:33
@czechboy0 czechboy0 added the 🔨 semver/patch No public API change. label Feb 26, 2026
@czechboy0
Copy link
Contributor

The intermittent Windows failures are expected to be addressed by apple/swift-nio#3520

@czechboy0
Copy link
Contributor

In the meantime I'll rekick it

@czechboy0
Copy link
Contributor

Also needs a formatting rerun

auto-merge was automatically disabled February 26, 2026 08:47

Head branch was pushed to by a user without write access

@czechboy0 czechboy0 enabled auto-merge (squash) February 26, 2026 09:26
@czechboy0 czechboy0 merged commit d34f76e into apple:main Feb 26, 2026
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🔨 semver/patch No public API change.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants