Open
Conversation
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of apple/swift-openapi-generator#868
This PR introduces a new default trait
FullFoundationSupport. If users remove this trait it does two things:ISO8601DateFormatterwith the new Foundation APIs.NSNullandNSNumberinOpenAPIValue.If non-darwin platforms disable this trait, its technically source breaking if they rely on the initializer of
ISO8601DateTranscoder, because it relies on theISO8601DateFormatter.Optionsobject. I am not sure how we would get around that. But again, it requires users to explicitly remove the trait, and thereby want to open in to only relying on FoundationEssentials. So imo its acceptable.I am not sure about CI. We really should be testing with and without the trait, but I could not find other examples that use the swift-nio jobs to do this. But if you could point me in the right direction, I can add that as well.
From what I understand from @FranzBusch, we also only have 1 chance of adding default traits. Are there any other traits we should think about introducing?