refactor(build): Reduce cyclomatic complexity of watchBuildPhase#98
Open
refactor(build): Reduce cyclomatic complexity of watchBuildPhase#98
Conversation
Fixes #95. When builds fail during prebuild phases (INSTALL, PRE_BUILD, etc.), users now see the relevant error logs instead of just a spinner. This helps users understand failures like malformed app.json or apppack.toml files. The implementation checks CodeBuild status (FAILED, STOPPED, TIMED_OUT) during prebuild phases and streams logs when failures are detected. This preserves existing UX for successful builds while providing error visibility for failures.
Extract helper functions to reduce cyclomatic complexity from 21 to improve maintainability: - isPreBuildPhase(): Check if phase is a prebuild phase - isBuildFailed(): Check if CodeBuild status indicates failure - handlePreBuildPhaseFailure(): Handle prebuild phase failures and show logs - startBuildLogTailing(): Start log tailing for BUILD phase - updatePreBuildSpinner(): Update spinner for prebuild phases Replaced complex if-else chain with cleaner switch statement for better readability.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
isPreBuildPhase()helper to check for pre-build phasesisBuildFailed()helper to check build failure statushandlePreBuildPhaseFailure()to handle failed pre-build phases with log displaystartBuildLogTailing()to manage build log streamingupdatePreBuildSpinner()to update spinner status for pre-build phasesThis refactoring maintains all existing functionality while making the code more maintainable and easier to understand.