[dkg] Add chunky DKG types and module structure #18542
Conversation
Adds the core Chunky DKG type definitions: - ChunkyDKGConfig, ChunkyDKGSessionMetadata, ChunkyDKGStartEvent - ChunkyDKGTranscript, CertifiedAggregatedChunkySubtranscript - ChunkyDKGSessionState, ChunkyDKGState - ChunkyDKG wrapper with deal/verify/aggregate helpers Also adds on-chain config types: - ChunkyDKGConfigMoveStruct, OnChainChunkyDKGConfig (Off/V1 variants) And exports InputSecret, EncryptPubKey, PublicParameters from aptos-dkg.
ibalajiarun
changed the base branch from
balaji/chunky-dkg-reconfig-vm
to
graphite-base/18542
ibalajiarun
force-pushed
the
graphite-base/18542
branch
from
3c691a6 to
46d8fbd
Compare
ibalajiarun
force-pushed
the
balaji/chunky-dkg-crate-types
branch
from
be3a963 to
2fd2bb8
Compare
ibalajiarun
changed the base branch from
graphite-base/18542
to
balaji/chunky-dkg-validator-txn
ibalajiarun
changed the base branch from
balaji/chunky-dkg-validator-txn
to
graphite-base/18542
ibalajiarun
force-pushed
the
balaji/chunky-dkg-crate-types
branch
from
2fd2bb8 to
920951f
Compare
ibalajiarun
force-pushed
the
graphite-base/18542
branch
from
46d8fbd to
222ea46
Compare
ibalajiarun
changed the base branch from
graphite-base/18542
to
balaji/chunky-dkg-types
- Add chunky module with types, placeholder submodules - Add ChunkyDKG message types to DKGMessage enum - Add chunky DKG metrics and observability functions - Add required dependencies to Cargo.toml
ibalajiarun
force-pushed
the
balaji/chunky-dkg-crate-types
branch
from
920951f to
90382e5
Compare
ibalajiarun
requested review from
JoshLind,
alinush,
danielxiangzl,
waamm,
zekun000 and
zjma
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| DKGMessage::ChunkyTranscriptRequest(_) => "ChunkyDKGTranscriptRequest", | ||
| DKGMessage::ChunkyTranscriptResponse(_) => "ChunkyDKGTranscriptResponse", | ||
| DKGMessage::SubtranscriptSignatureRequest(_) => "DKGSubtranscriptSignatureRequest", | ||
| DKGMessage::SubtranscriptSignatureResponse(_) => "DKGSubtranscriptSignatureResponse", |
There was a problem hiding this comment.
Inconsistent naming missing "Chunky" prefix in name() method
Low Severity
The name() method returns "DKGSubtranscriptSignatureRequest" and "DKGSubtranscriptSignatureResponse" for the SubtranscriptSignatureRequest and SubtranscriptSignatureResponse variants, but the actual wrapped types are ChunkyDKGSubtranscriptSignatureRequest and ChunkyDKGSubtranscriptSignatureResponse. This is inconsistent with the pattern used for ChunkyTranscriptRequest and ChunkyTranscriptResponse, which correctly include the "Chunky" prefix in their returned names. Since name() is used for logging/debugging in error messages, this inconsistency could cause confusion when searching for or identifying these message types.
| DKG_STAGE_SECONDS | ||
| .with_label_values(&[my_addr.short_str().as_str(), stage]) | ||
| .observe(secs_since_dkg_start); | ||
| } |
There was a problem hiding this comment.
Metric label format inconsistent with existing DKG code
Low Severity
The new observe_dkg_stage function uses my_addr.short_str() to format the dealer label, but existing code in dkg_manager/mod.rs records to the same DKG_STAGE_SECONDS metric using self.my_addr.to_hex(). short_str() returns only the first 8 hex characters while to_hex() returns the full 64-character address. If this function is ever enabled, the same dealer would appear as different entities in metrics, making analysis difficult.
| #[derive(Clone, Debug, Serialize, Deserialize, CryptoHasher, BCSCryptoHash)] | ||
| pub struct AggregatedSubtranscript { | ||
| pub subtranscript: ChunkySubtranscript, | ||
| pub dealers: Vec<Player>, |
| #[derive(Clone, Serialize, Deserialize, Debug, PartialEq)] | ||
| pub struct MissingTranscriptResponse { | ||
| pub metadata: DKGTranscriptMetadata, | ||
| pub transcript: ChunkyDKGTranscriptResponse, |
There was a problem hiding this comment.
transcript already has metadata?
Summary
Adds the
dkg/src/chunky/module structure with types and stubs.types.rs- Network message typesChunkyDKGTranscriptRequest/Response- for collecting transcripts from peersMissingTranscriptRequest/Response- for fetching missing transcriptsAggregatedSubtranscript- aggregated result with contributorsCertifiedAggregatedSubtranscript- aggregated result with multi-sigModule structure (stubs for subsequent PRs)
agg_subtrx_producer.rs- aggregated subtranscript producersubtrx_cert_producer.rs- subtranscript certificate producerdkg_manager.rs- DKG state machinemissing_transcript_fetcher.rs- transcript fetcherDependencies
aptos-dkg,aptos-batch-encryption,aptos-short-hex-str,serde_bytes