Skip to content

Conversation

@wqfish
Copy link
Contributor

@wqfish wqfish commented Jan 30, 2026

Note

Medium Risk
Updates the default on-chain execution config version and adds new serialized fields, which can affect genesis config generation and on-chain config compatibility if downstream components aren’t updated to understand V8.

Overview
Adds OnChainExecutionConfig::V8 and a new HotStateConfig enum (with genesis defaults) to carry hot-state tuning parameters on-chain, and switches default_for_genesis() to emit V8.

Updates forge suite genesis overrides (dag.rs, realistic_environment.rs) to handle V8 when mutating execution config fields (e.g., block_gas_limit_type, transaction_shuffler_type) so tests continue to work with the new default version.

Written by Cursor Bugbot for commit 3f36b73. This will update automatically on new commits. Configure here.

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

pub gas_price_to_burn: u64,
pub persisted_auxiliary_info_version: u8,
pub hot_state_config: HotStateConfig,
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing getter method for hot_state_config field

Medium Severity

The ExecutionConfigV8 struct adds a new hot_state_config field, but there's no corresponding pub fn hot_state_config(&self) -> HotStateConfig getter method on OnChainExecutionConfig. Every other field in the config struct (transaction_shuffler_type, block_gas_limit_type, enable_per_block_gas_limit, transaction_deduper_type, gas_price_to_burn, persisted_auxiliary_info_version) has a public getter. Without the getter, consumers of OnChainExecutionConfig cannot access the hot_state_config value through the public interface.

Fix in Cursor Fix in Web

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants