Skip to content

Conversation

@wqfish
Copy link
Contributor

@wqfish wqfish commented Jan 30, 2026

Note

Medium Risk
Medium risk because it upgrades the Rust toolchain and LLVM/Clang version, which can surface new compiler/lint behavior and CI/build differences; code changes are otherwise largely mechanical (defaults/array literals) and test-only.

Overview
Upgrades build toolchain to Rust 1.91.1, and bumps builder/dev setup Clang default to 21.

Cleans up Rust 1.91-related code patterns by deriving Default on multiple enums (replacing manual impl Default) and by converting many single-use vec![...] constructions to array/slice literals (especially around commit_block/test data), plus a small test assertion simplification in simulation_test.rs.

Written by Cursor Bugbot for commit ffdd517. This will update automatically on new commits. Configure here.

@wqfish wqfish added CICD:run-e2e-tests when this label is present github actions will run all land-blocking e2e tests from the PR CICD:build-performance-images build performance docker image variants labels Jan 30, 2026
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

✅ Forge suite compat success on 1543a9cac46a100c4ab4cafe6b3f2c35bd50538c ==> ffdd51704e6fe434f0c39ad50b845be5bb4def41

Compatibility test results for 1543a9cac46a100c4ab4cafe6b3f2c35bd50538c ==> ffdd51704e6fe434f0c39ad50b845be5bb4def41 (PR)
1. Check liveness of validators at old version: 1543a9cac46a100c4ab4cafe6b3f2c35bd50538c
compatibility::simple-validator-upgrade::liveness-check : committed: 14314.10 txn/s, latency: 2429.37 ms, (p50: 2500 ms, p70: 2700, p90: 3000 ms, p99: 3300 ms), latency samples: 466820
2. Upgrading first Validator to new version: ffdd51704e6fe434f0c39ad50b845be5bb4def41
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 5821.10 txn/s, latency: 5838.55 ms, (p50: 6500 ms, p70: 6600, p90: 6700 ms, p99: 6800 ms), latency samples: 199140
3. Upgrading rest of first batch to new version: ffdd51704e6fe434f0c39ad50b845be5bb4def41
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 5873.45 txn/s, latency: 5796.95 ms, (p50: 6500 ms, p70: 6600, p90: 6600 ms, p99: 6700 ms), latency samples: 200800
4. upgrading second batch to new version: ffdd51704e6fe434f0c39ad50b845be5bb4def41
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 9560.66 txn/s, latency: 3543.45 ms, (p50: 3800 ms, p70: 3900, p90: 4100 ms, p99: 4200 ms), latency samples: 312320
5. check swarm health
Compatibility test for 1543a9cac46a100c4ab4cafe6b3f2c35bd50538c ==> ffdd51704e6fe434f0c39ad50b845be5bb4def41 passed
Test Ok

@github-actions
Copy link
Contributor

✅ Forge suite realistic_env_max_load success on ffdd51704e6fe434f0c39ad50b845be5bb4def41

two traffics test: inner traffic : committed: 13631.03 txn/s, latency: 2764.52 ms, (p50: 2700 ms, p70: 2900, p90: 3000 ms, p99: 3600 ms), latency samples: 5074740
two traffics test : committed: 100.01 txn/s, latency: 743.38 ms, (p50: 700 ms, p70: 800, p90: 800 ms, p99: 1000 ms), latency samples: 1740
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 2.248, avg: 2.178", "ConsensusProposalToOrdered: max: 0.169, avg: 0.166", "ConsensusOrderedToCommit: max: 0.050, avg: 0.045", "ConsensusProposalToCommit: max: 0.216, avg: 0.210"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.42s no progress at version 1413315 (avg 0.07s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.31s no progress at version 2369831 (avg 0.31s) [limit 16].
Test Ok

@wqfish wqfish marked this pull request as ready for review January 30, 2026 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CICD:build-performance-images build performance docker image variants CICD:run-e2e-tests when this label is present github actions will run all land-blocking e2e tests from the PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants