vmss app gateway enabled#1847
Open
abdullahaslam306 wants to merge 1 commit intoaquasecurity:masterfrom
Open
Conversation
alphadev4
reviewed
Jan 31, 2024
| "main": "index.js", | ||
| "scripts": { | ||
| "test": "mocha './**/*.spec.js'", | ||
| "test": "mocha './**/vmssApplicationGatewayEnabled.spec.js'", |
Collaborator
There was a problem hiding this comment.
Suggested change
| "test": "mocha './**/vmssApplicationGatewayEnabled.spec.js'", | |
| "test": "mocha './**/*.spec.js'", |
alphadev4
reviewed
Jan 31, 2024
| category: 'Virtual Machine Scale Set', | ||
| domain: 'Compute', | ||
| description: 'Ensures that Azure Virtual Machine scale sets has Application Gateway enabled.', | ||
| more_info: 'Tags help you to group resources together that are related to or associated with each other. It is a best practice to tag cloud resources to better organize and gain visibility into their usage.', |
Collaborator
There was a problem hiding this comment.
it should be relevant to the plugin
alphadev4
reviewed
Jan 31, 2024
| link: 'https://learn.microsoft.com/en-us/azure/virtual-machine-scale-sets/virtual-machine-scale-sets-networking?tabs=portal1', | ||
| recommended_action: 'Modify VM scale set and add application gateway.', | ||
| apis: ['virtualMachineScaleSets:listAll'], | ||
|
|
alphadev4
requested changes
Jan 31, 2024
| title: 'VM Scale Set Application Gateway Enabled', | ||
| category: 'Virtual Machine Scale Set', | ||
| domain: 'Compute', | ||
| description: 'Ensures that Azure Virtual Machine scale sets has Application Gateway enabled.', |
Collaborator
There was a problem hiding this comment.
i think application gateway is not something that can be enabled. instead its something that we configure or add, so can you change the description and messages accordingly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.