Allocate dyamic sized arrays#141
Open
ollie1400 wants to merge 3 commits intoarduino-libraries:masterfrom
Open
Conversation
|
|
alranel
added a commit
to rduino-libraries/rduinoBLE
that referenced
this pull request
May 7, 2022
ollie1400
force-pushed
the
AllocateDynamicArrays
branch
from
0be0d09 to
b9c1358
Compare
per1234
added
type: imperfection
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In response to issue #89
Rather than make a variable sized buffer (is that somehow supported?), allocate a correctly sized buffer.
Alternative might be to have a fixed size TX buffer to avoid allocations/reallocations...