Add function to manage low power mode status#327
Open
leonardocavagnis wants to merge 5 commits intoarduino-libraries:masterfrom
Open
Add function to manage low power mode status#327leonardocavagnis wants to merge 5 commits intoarduino-libraries:masterfrom
leonardocavagnis wants to merge 5 commits intoarduino-libraries:masterfrom
Conversation
per1234
added
type: enhancement
sebromero
requested changes
Oct 24, 2023
Contributor
sebromero
left a comment
sebromero
left a comment
There was a problem hiding this comment.
Thank you for the PR! I'd recommend naming the user facing function setLowPowerModeEnabled or as discussed disableLowPowerMode() if re-enabling it makes no sense. For the other functions I suggest avoiding abbreviations that leave room for ambiguity.
Co-authored-by: Sebastian Romero <s.romero.zh@gmail.com>
Co-authored-by: Sebastian Romero <s.romero.zh@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding the function
BLE.setLowPowerMode(bool)to manage the lower power mode status of the BLE chip.The function
BLE.setLowPowerMode(bool)(true: to enable,false: to disable) must be called before executing theBLE.begin()function. Using this function after the BLE stack initialization will not have any effect.The function does not directly control the entry and exit from low power mode but enables or disables the chip's feature.
Low power mode is enabled by default.
@sebromero Check it out if function name sounds good. Another proposal could be using two different functions:
enableLowPowerMode()anddisableLowPowerMode().This PR is based on the arduino/mbed-os PR #32.