Conversation
gabriel-barrett
force-pushed
the
new-serialization
branch
from
4eef4c8 to
273385b
Compare
arthurpaulino
previously approved these changes
Feb 20, 2026
Comment on lines
+84
to
+92
| fn put_u64_le(bs: [G; 8], num_bytes: G) -> ByteStream { | ||
| match num_bytes { | ||
| 0 => ByteStream.Nil, | ||
| _ => | ||
| let [b1, b2, b3, b4, b5, b6, b7, b8] = bs; | ||
| let rest = [b2, b3, b4, b5, b6, b7, b8, 0]; | ||
| ByteStream.Cons(b1, store(put_u64_le(rest, num_bytes - 1))), | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
How do you think this implementation compares against manually writing all 9 cases (from 0 to 8)?
It would prevent recursions, making the trace shorter, avoiding potential exponential leaps (which entail dummy rows).
Member
Author
There was a problem hiding this comment.
I don't know tbh. But I think it shouldn't matter too much at this stage
Comment on lines
+59
to
+64
| fn u64_is_zero(x: [G; 8]) -> G { | ||
| match x { | ||
| [0, 0, 0, 0, 0, 0, 0, 0] => 1, | ||
| _ => 0, | ||
| } | ||
| } |
johnchandlerburnham
approved these changes
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds serialization for Ixon expressions. There are a few repetitive functions, like
put_x_telescopeandx_telescope_count. I decided not to stress too much with these things, and leave it for a later optimization to remove them. For instance, we could probably introduce an enum that identifies which telescope it is and have a generic telescope function that uses the tag. Also, we could use non-determinism to not have to compute the size of the telescope in circuit