Conversation
samuelburnham
force-pushed
the
lean-v4.27.0
branch
from
1edd633 to
1cc864f
Compare
samuelburnham
force-pushed
the
lean-v4.27.0
branch
from
1cc864f to
72f5232
Compare
Member
arthurpaulino
left a comment
arthurpaulino
left a comment
There was a problem hiding this comment.
Thanks! These periodic bumps are extremely important.
I just left one comment to simplify/improve our tests.
Comment on lines
-28
to
-30
| ("aiur", Tests.Aiur.suite), | ||
| ("aiur-hashes", Tests.AiurHashes.suite), | ||
| ("ixvm", Tests.IxVM.suite), |
Member
There was a problem hiding this comment.
If we're removing these from the primary test suites, then we no longer need the Aiur/AiurMain, AiurHashes/AiurHashesMain and IxVM/IxVMMain duals.
Their main functions can be moved to Aiur.lean, AiurHashes.lean and IxVM.lean respectively. And their "*Main" counterparts can be removed.
Finally, their declarations in the lakefile.lean will have to be updated, pointing to the right files.
Optionally, but maybe preferably, those files could be moved to a Tests/Standalone folder so their finality becomes more explicit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Next step: Switch to new module system