Skip to content

Add repro test for duplicate split migration names#724

Merged
zachdaniel merged 3 commits intoash-project:mainfrom
jechol:repro/duplicate-split-migration-names
Mar 20, 2026
Merged

Add repro test for duplicate split migration names#724
zachdaniel merged 3 commits intoash-project:mainfrom
jechol:repro/duplicate-split-migration-names

Conversation

@jechol
Copy link
Copy Markdown
Contributor

@jechol jechol commented Mar 20, 2026

Adds a failing regression test for duplicate migration names/modules when a single generation run is split into multiple migration files.

This is a minimal reproduction of #723.

This repro uses a concurrent custom index together with an explicit name: "repro_case".

The generated files end up with the same explicit suffix:

  • 20260320063017_repro_case.exs
  • 20260320063018_repro_case.exs

and both define the same migration module:

  • AshPostgres.TestRepo.Migrations.ReproCase

That means split migrations are not deriving unique names/modules from the provided base name.

This PR is intended as a minimal repro only.

Contributor checklist

Leave anything that you believe does not apply unchecked.

  • I accept the AI Policy, or AI was not used in the creation of this PR.
  • Bug fixes include regression tests
  • Chores
  • Documentation changes
  • Features include unit/acceptance tests
  • Refactoring
  • Update dependencies

@zachdaniel zachdaniel merged commit 23a4df0 into ash-project:main Mar 20, 2026
25 of 30 checks passed
@jechol jechol deleted the repro/duplicate-split-migration-names branch March 22, 2026 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants