Add repro test for duplicate split migration names#724
Merged
zachdaniel merged 3 commits intoash-project:mainfrom Mar 20, 2026
Merged
Add repro test for duplicate split migration names#724zachdaniel merged 3 commits intoash-project:mainfrom
zachdaniel merged 3 commits intoash-project:mainfrom
Conversation
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a failing regression test for duplicate migration names/modules when a single generation run is split into multiple migration files.
This is a minimal reproduction of #723.
This repro uses a concurrent custom index together with an explicit
name: "repro_case".The generated files end up with the same explicit suffix:
20260320063017_repro_case.exs20260320063018_repro_case.exsand both define the same migration module:
AshPostgres.TestRepo.Migrations.ReproCaseThat means split migrations are not deriving unique names/modules from the provided base name.
This PR is intended as a minimal repro only.
Contributor checklist
Leave anything that you believe does not apply unchecked.