Open
Conversation
added 2 commits
October 30, 2021 14:31
The `#` symbol was causing the symlink that npm creates to point at just `/source/` rather than `/source/#external/`
This allows `./sl roslyn-branches` to work after running `./sl setup` (before it just complained about missing modules)
Owner
|
Thanks for raising this! I'll take a look now. |
ashmind
reviewed
Nov 2, 2021
| "lz-string": "1.4.4", | ||
| "marked": "0.7.0", | ||
| "mirrorsharp": "file:../#external/mirrorsharp/WebAssets/dist", | ||
| "mirrorsharp": "file:../%23external/mirrorsharp/WebAssets/dist", |
Owner
There was a problem hiding this comment.
Not fully sure about this one -- I think I tried this before and run into some problems.
I'll need to try it out again before merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes two issues I ran into getting the project to build and run locally.
I also ran into an issues with with the WebApp project finding duplicate dependencies, but I just disabled the check to workaround it so that isn't included here. I'll open a separate issue.