Skip to content

fix(ts_proto_library): don't path .js/.d.ts emit following _virtual_imports#874

Open
alexeagle wants to merge 6 commits intomainfrom
repro_476_2
Open

fix(ts_proto_library): don't path .js/.d.ts emit following _virtual_imports#874
alexeagle wants to merge 6 commits intomainfrom
repro_476_2

Conversation

@alexeagle
Copy link
Copy Markdown
Contributor

@alexeagle alexeagle commented Dec 17, 2025

#819 created a changed proto but it wasn't imported anywhere. So it wasn't quite the right fix.

ERROR: /Users/alexeagle/Projects/rules_ts/examples/proto_grpc/BUILD.bazel:52:11: Transpiling (js) & type-checking TypeScript project @@//examples/proto_grpc:proto_grpc [tsc -p examples/proto_grpc/tsconfig.json] failed: (Exit 2): tsc failed: error executing TsProject command (from target //examples/proto_grpc:proto_grpc) bazel-out/darwin_arm64-opt-exec-ST-d57f47055a04/bin/external/_main~ext~npm_typescript/tsc_/tsc --project examples/proto_grpc/tsconfig.json --rootDir examples/proto_grpc --declaration false

Use --sandbox_debug to see verbose messages from the sandbox and retain the sandbox build root for debugging
examples/proto_grpc/main.ts(2,29): error TS2307: Cannot find module './stripping/s_pb.js' or its corresponding type declarations.
INFO: Elapsed time: 2.475s, Critical Path: 2.01s
INFO: 47 processes: 22 internal, 20 darwin-sandbox, 5 local.
ERROR: Build did NOT complete successfully

fixes #476

#819 created a changed proto but it wasn't imported anywhere
@alexeagle alexeagle mentioned this pull request Dec 17, 2025
@aspect-workflows
Copy link
Copy Markdown

aspect-workflows Bot commented Dec 17, 2025

Test (Bazel 6.x) (Test)

⚠️ Buildkite build #445 failed.

//ts/test:verbose_true_ts failed to build

tsc failed: error executing command (from target //ts/test:verbose_true_ts) bazel-out/k8-opt-exec-2B5CBBC6-ST-2e838ac439b8/bin/external/_main~ext~npm_typescript/tsc_/tsc --listFiles --listEmittedFiles --traceResolution --diagnostics --extendedDiagnostics --project ... (remaining 3 arguments skipped)
 
Use --sandbox_debug to see verbose messages from the sandbox and retain the sandbox build root for debugging
 
src/main/tools/linux-sandbox-pid1.cc:315: "mount(/mnt/ephemeral/output/rules_ts/__main__/sandbox/linux-sandbox/902/_tmp, /tmp, nullptr, MS_BIND, nullptr)": No such file or directory

@_main~ext~npm_typescript//:copy_validator failed to build

bash failed: error executing command (from target @_main~ext~npm_typescript//:copy_validator) /bin/bash -c 'cp -f "$1" "$2"' '' ts/private/ts_project_options_validator.cjs bazel-out/k8-opt-exec-2B5CBBC6/bin/external/_main~ext~npm_typescript/ts_project_options_validator.cjs
 
Use --sandbox_debug to see verbose messages from the sandbox and retain the sandbox build root for debugging
 
src/main/tools/linux-sandbox-pid1.cc:315: "mount(/mnt/ephemeral/output/rules_ts/__main__/sandbox/linux-sandbox/9/_tmp, /tmp, nullptr, MS_BIND, nullptr)": No such file or directory

//examples:.aspect_rules_js/node_modules/typescript@5.7.3/pkg failed to build

bash failed: error executing command (from target //examples:.aspect_rules_js/node_modules/typescript@5.7.3/pkg) /bin/bash -c '$1 --extract --no-same-owner --no-same-permissions --strip-components 1 --file $2 --directory $3 && chmod -R a+X $3' '' external/aspect_bazel_lib~2.14.0~toolchains~bsd_tar_linux_amd64/tar ... (remaining 2 arguments skipped)
 
Use --sandbox_debug to see verbose messages from the sandbox and retain the sandbox build root for debugging
 
src/main/tools/linux-sandbox-pid1.cc:315: "mount(/mnt/ephemeral/output/rules_ts/__main__/sandbox/linux-sandbox/348/_tmp, /tmp, nullptr, MS_BIND, nullptr)": No such file or directory

//examples:.aspect_rules_js/node_modules/@types+node@22.0.0/pkg failed to build

bash failed: error executing command (from target //examples:.aspect_rules_js/node_modules/@types+node@22.0.0/pkg) /bin/bash -c '$1 --extract --no-same-owner --no-same-permissions --strip-components 1 --file $2 --directory $3 && chmod -R a+X $3' '' external/aspect_bazel_lib~2.14.0~toolchains~bsd_tar_linux_amd64/tar ... (remaining 2 arguments skipped)
 
Use --sandbox_debug to see verbose messages from the sandbox and retain the sandbox build root for debugging
 
src/main/tools/linux-sandbox-pid1.cc:315: "mount(/mnt/ephemeral/output/rules_ts/__main__/sandbox/linux-sandbox/661/_tmp, /tmp, nullptr, MS_BIND, nullptr)": No such file or directory

//examples/linked_tsconfig_consumer:lib failed to build

tsc failed: error executing command (from target //examples/linked_tsconfig_consumer:lib) bazel-out/k8-opt-exec-2B5CBBC6/bin/external/_main~ext~npm_typescript/tsc_/tsc --project examples/linked_tsconfig_consumer/tsconfig.json --rootDir examples/linked_tsconfig_consumer --declaration false
 
Use --sandbox_debug to see verbose messages from the sandbox and retain the sandbox build root for debugging
 
src/main/tools/linux-sandbox-pid1.cc:315: "mount(/mnt/ephemeral/output/rules_ts/__main__/sandbox/linux-sandbox/708/_tmp, /tmp, nullptr, MS_BIND, nullptr)": No such file or directory

106 other actions failed to build.

💡 To reproduce the build failures, run

bazel build --output_groups=+types //ts/test:verbose_true_ts @_main~ext~npm_typescript//:copy_validator //examples:.aspect_rules_js/node_modules/typescript@5.7.3/pkg //examples:.aspect_rules_js/node_modules/@types+node@22.0.0/pkg //examples/linked_tsconfig_consumer:lib

Test (Bazel 7.x) (Test)

⚠️ Buildkite build #445 failed.

//examples/custom_compiler:angular failed to build

ngc failed: error executing TsProject command (from target //examples/custom_compiler:angular) bazel-out/k8-opt-exec-ST-d57f47055a04/bin/examples/custom_compiler/ngc_/ngc --project examples/custom_compiler/tsconfig.json --rootDir examples/custom_compiler --declaration false
 
Use --sandbox_debug to see verbose messages from the sandbox and retain the sandbox build root for debugging
 
error TS500: Error: The Angular Compiler requires TypeScript >=5.4.0 and <5.7.0 but 5.7.3 was found instead.
    at checkVersion (file:///mnt/ephemeral/output/rules_ts/__main__/sandbox/linux-sandbox/824/execroot/_main/bazel-out/k8-opt-exec-ST-d57f47055a04/bin/examples/custom_compiler/ngc_/ngc.runfiles/_main/examples/node_modules/.aspect_rules_js/@angular+compiler-cli@19.0.0-next.2_1463032538/node_modules/@angular/compiler-cli/bundles/chunk-LYN2P66H.js:1093:11)
    at verifySupportedTypeScriptVersion (file:///mnt/ephemeral/output/rules_ts/__main__/sandbox/linux-sandbox/824/execroot/_main/bazel-out/k8-opt-exec-ST-d57f47055a04/bin/examples/custom_compiler/ngc_/ngc.runfiles/_main/examples/node_modules/.aspect_rules_js/@angular+compiler-cli@19.0.0-next.2_1463032538/node_modules/@angular/compiler-cli/bundles/chunk-LYN2P66H.js:1097:3)
    at new NgtscProgram (file:///mnt/ephemeral/output/rules_ts/__main__/sandbox/linux-sandbox/824/execroot/_main/bazel-out/k8-opt-exec-ST-d57f47055a04/bin/examples/custom_compiler/ngc_/ngc.runfiles/_main/examples/node_modules/.aspect_rules_js/@angular+compiler-cli@19.0.0-next.2_1463032538/node_modules/@angular/compiler-cli/bundles/chunk-LYN2P66H.js:4277:7)
    at createProgram (file:///mnt/ephemeral/output/rules_ts/__main__/sandbox/linux-sandbox/824/execroot/_main/bazel-out/k8-opt-exec-ST-d57f47055a04/bin/examples/custom_compiler/ngc_/ngc.runfiles/_main/examples/node_modules/.aspect_rules_js/@angular+compiler-cli@19.0.0-next.2_1463032538/node_modules/@angular/compiler-cli/bundles/chunk-LYN2P66H.js:4498:10)
    at performCompilation (file:///mnt/ephemeral/output/rules_ts/__main__/sandbox/linux-sandbox/824/execroot/_main/bazel-out/k8-opt-exec-ST-d57f47055a04/bin/examples/custom_compiler/ngc_/ngc.runfiles/_main/examples/node_modules/.aspect_rules_js/@angular+compiler-cli@19.0.0-next.2_1463032538/node_modules/@angular/compiler-cli/bundles/chu

... 1201 chars truncated

//ts/test:_ts_proto_library_with_dep_protoc failed to build

not all outputs were created or valid

💡 To reproduce the build failures, run

bazel build --output_groups=+types //examples/custom_compiler:angular //ts/test:_ts_proto_library_with_dep_protoc

Test (Bazel 8.x) (Test)

⚠️ Buildkite build #445 failed.

//examples/custom_compiler:angular failed to build

ngc failed: error executing TsProject command (from target //examples/custom_compiler:angular) bazel-out/k8-opt-exec-ST-d57f47055a04/bin/examples/custom_compiler/ngc_/ngc --project examples/custom_compiler/tsconfig.json --rootDir examples/custom_compiler --declaration false
 
Use --sandbox_debug to see verbose messages from the sandbox and retain the sandbox build root for debugging
 
error TS500: Error: The Angular Compiler requires TypeScript >=5.4.0 and <5.7.0 but 5.7.3 was found instead.
    at checkVersion (file:///mnt/ephemeral/output/rules_ts/__main__/sandbox/linux-sandbox/614/execroot/_main/bazel-out/k8-opt-exec-ST-d57f47055a04/bin/examples/custom_compiler/ngc_/ngc.runfiles/_main/examples/node_modules/.aspect_rules_js/@angular+compiler-cli@19.0.0-next.2_1463032538/node_modules/@angular/compiler-cli/bundles/chunk-LYN2P66H.js:1093:11)
    at verifySupportedTypeScriptVersion (file:///mnt/ephemeral/output/rules_ts/__main__/sandbox/linux-sandbox/614/execroot/_main/bazel-out/k8-opt-exec-ST-d57f47055a04/bin/examples/custom_compiler/ngc_/ngc.runfiles/_main/examples/node_modules/.aspect_rules_js/@angular+compiler-cli@19.0.0-next.2_1463032538/node_modules/@angular/compiler-cli/bundles/chunk-LYN2P66H.js:1097:3)
    at new NgtscProgram (file:///mnt/ephemeral/output/rules_ts/__main__/sandbox/linux-sandbox/614/execroot/_main/bazel-out/k8-opt-exec-ST-d57f47055a04/bin/examples/custom_compiler/ngc_/ngc.runfiles/_main/examples/node_modules/.aspect_rules_js/@angular+compiler-cli@19.0.0-next.2_1463032538/node_modules/@angular/compiler-cli/bundles/chunk-LYN2P66H.js:4277:7)
    at createProgram (file:///mnt/ephemeral/output/rules_ts/__main__/sandbox/linux-sandbox/614/execroot/_main/bazel-out/k8-opt-exec-ST-d57f47055a04/bin/examples/custom_compiler/ngc_/ngc.runfiles/_main/examples/node_modules/.aspect_rules_js/@angular+compiler-cli@19.0.0-next.2_1463032538/node_modules/@angular/compiler-cli/bundles/chunk-LYN2P66H.js:4498:10)
    at performCompilation (file:///mnt/ephemeral/output/rules_ts/__main__/sandbox/linux-sandbox/614/execroot/_main/bazel-out/k8-opt-exec-ST-d57f47055a04/bin/examples/custom_compiler/ngc_/ngc.runfiles/_main/examples/node_modules/.aspect_rules_js/@angular+compiler-cli@19.0.0-next.2_1463032538/node_modules/@angular/compiler-cli/bundles/chu

... 1201 chars truncated

//ts/test:_ts_proto_library_with_dep_protoc failed to build

not all outputs were created or valid

💡 To reproduce the build failures, run

bazel build --output_groups=+types //examples/custom_compiler:angular //ts/test:_ts_proto_library_with_dep_protoc

Bazel-7

e2e/bzlmodules

All tests were cache hits

1 test (100.0%) was fully cached saving 32ms.


Bazel-8

e2e/bzlmodules

All tests were cache hits

1 test (100.0%) was fully cached saving 30ms.


Bazel-6

e2e/external_dep

⚠️ Buildkite build #445 failed.

@aspect_rules_ts~override~ext~npm_typescript//:copy_validator failed to build

bash failed: error executing command (from target @aspect_rules_ts~override~ext~npm_typescript//:copy_validator) /bin/bash -c 'cp -f "$1" "$2"' '' external/aspect_rules_ts~override/ts/private/ts_project_options_validator.cjs ... (remaining 1 argument skipped)
 
Use --sandbox_debug to see verbose messages from the sandbox and retain the sandbox build root for debugging
 
src/main/tools/linux-sandbox-pid1.cc:315: "mount(/mnt/ephemeral/output/rules_ts/e2e_external_dep/sandbox/linux-sandbox/6/_tmp, /tmp, nullptr, MS_BIND, nullptr)": No such file or directory

@aspect_rules_ts~override~ext~npm_typescript2//:copy_validator failed to build

bash failed: error executing command (from target @aspect_rules_ts~override~ext~npm_typescript2//:copy_validator) /bin/bash -c 'cp -f "$1" "$2"' '' external/aspect_rules_ts~override/ts/private/ts_project_options_validator.cjs ... (remaining 1 argument skipped)
 
Use --sandbox_debug to see verbose messages from the sandbox and retain the sandbox build root for debugging
 
src/main/tools/linux-sandbox-pid1.cc:315: "mount(/mnt/ephemeral/output/rules_ts/e2e_external_dep/sandbox/linux-sandbox/9/_tmp, /tmp, nullptr, MS_BIND, nullptr)": No such file or directory

💡 To reproduce the build failures, run

bazel build @aspect_rules_ts~override~ext~npm_typescript//:copy_validator @aspect_rules_ts~override~ext~npm_typescript2//:copy_validator

Bazel-7

e2e/external_dep

All tests were cache hits

6 tests (100.0%) were fully cached saving 289ms.


Bazel-8

e2e/external_dep

All tests were cache hits

6 tests (100.0%) were fully cached saving 291ms.


Bazel-7

e2e/smoke

All tests were cache hits

2 tests (100.0%) were fully cached saving 107ms.


Bazel-8

e2e/smoke

All tests were cache hits

2 tests (100.0%) were fully cached saving 149ms.


Bazel-6

e2e/test

⚠️ Buildkite build #445 failed.

//examples:.aspect_rules_js/node_modules/@typescript+vfs@1.6.2_typescript_5.4.5/pkg failed to build

bash failed: error executing command (from target //examples:.aspect_rules_js/node_modules/@typescript+vfs@1.6.2_typescript_5.4.5/pkg) /bin/bash -c '$1 --extract --no-same-owner --no-same-permissions --strip-components 1 --file $2 --directory $3 && chmod -R a+X $3' '' external/aspect_bazel_lib~2.14.0~toolchains~bsd_tar_linux_amd64/tar ... (remaining 2 arguments skipped)
 
Use --sandbox_debug to see verbose messages from the sandbox and retain the sandbox build root for debugging
 
src/main/tools/linux-sandbox-pid1.cc:315: "mount(/mnt/ephemeral/output/rules_ts/e2e_test/sandbox/linux-sandbox/750/_tmp, /tmp, nullptr, MS_BIND, nullptr)": No such file or directory

//examples/resolve_json_module_transpiler:ts-dict-unspecified failed to build

tsc failed: error executing command (from target //examples/resolve_json_module_transpiler:ts-dict-unspecified) bazel-out/k8-opt-exec-2B5CBBC6/bin/external/_main~ext~npm_typescript/tsc_/tsc --outDir examples/resolve_json_module_transpiler/ts-dict-unspecified --project ... (remaining 4 arguments skipped)
 
Use --sandbox_debug to see verbose messages from the sandbox and retain the sandbox build root for debugging
 
src/main/tools/linux-sandbox-pid1.cc:315: "mount(/mnt/ephemeral/output/rules_ts/e2e_test/sandbox/linux-sandbox/780/_tmp, /tmp, nullptr, MS_BIND, nullptr)": No such file or directory

//examples/resolve_json_module_transpiler:ts failed to build

tsc failed: error executing command (from target //examples/resolve_json_module_transpiler:ts) bazel-out/k8-opt-exec-2B5CBBC6/bin/external/_main~ext~npm_typescript/tsc_/tsc --project examples/resolve_json_module_transpiler/tsconfig.json --rootDir examples/resolve_json_module_transpiler --noEmit
 
Use --sandbox_debug to see verbose messages from the sandbox and retain the sandbox build root for debugging
 
src/main/tools/linux-sandbox-pid1.cc:315: "mount(/mnt/ephemeral/output/rules_ts/e2e_test/sandbox/linux-sandbox/782/_tmp, /tmp, nullptr, MS_BIND, nullptr)": No such file or directory

//examples/srcs:srcs-auto failed to build

tsc failed: error executing command (from target //examples/srcs:srcs-auto) bazel-out/k8-opt-exec-2B5CBBC6/bin/external/_main~ext~npm_typescript/tsc_/tsc --outDir examples/srcs/auto --project examples/srcs/tsconfig.json --rootDir examples/srcs --declaration false
 
Use --sandbox_debug to see verbose messages from the sandbox and retain the sandbox build root for debugging
 
src/main/tools/linux-sandbox-pid1.cc:315: "mount(/mnt/ephemeral/output/rules_ts/e2e_test/sandbox/linux-sandbox/808/_tmp, /tmp, nullptr, MS_BIND, nullptr)": No such file or directory

//examples/typecheck_only:typecheck_only failed to build

tsc failed: error executing command (from target //examples/typecheck_only:typecheck_only) bazel-out/k8-opt-exec-2B5CBBC6/bin/external/_main~ext~npm_typescript/tsc_/tsc --project examples/typecheck_only/tsconfig_typecheck_only.json --rootDir examples/typecheck_only --noEmit
 
Use --sandbox_debug to see verbose messages from the sandbox and retain the sandbox build root for debugging
 
src/main/tools/linux-sandbox-pid1.cc:315: "mount(/mnt/ephemeral/output/rules_ts/e2e_test/sandbox/linux-sandbox/867/_tmp, /tmp, nullptr, MS_BIND, nullptr)": No such file or directory

106 other actions failed to build.

💡 To reproduce the build failures, run

bazel build --output_groups=+typecheck --output_groups=+types //examples:.aspect_rules_js/node_modules/@typescript+vfs@1.6.2_typescript_5.4.5/pkg //examples/resolve_json_module_transpiler:ts-dict-unspecified //examples/resolve_json_module_transpiler:ts //examples/srcs:srcs-auto //examples/typecheck_only:typecheck_only

Bazel-7

e2e/test

⚠️ Buildkite build #445 failed.

//ts/test:_ts_proto_library_with_dep_protoc failed to build

not all outputs were created or valid

//examples/custom_compiler:angular failed to build

ngc failed: error executing TsProject command (from target //examples/custom_compiler:angular) bazel-out/k8-opt-exec-ST-d57f47055a04/bin/examples/custom_compiler/ngc_/ngc --project examples/custom_compiler/tsconfig.json --rootDir examples/custom_compiler --declaration false
 
Use --sandbox_debug to see verbose messages from the sandbox and retain the sandbox build root for debugging
 
error TS500: Error: The Angular Compiler requires TypeScript >=5.4.0 and <5.7.0 but 5.7.3 was found instead.
    at checkVersion (file:///mnt/ephemeral/output/rules_ts/e2e_test/sandbox/linux-sandbox/839/execroot/_main/bazel-out/k8-opt-exec-ST-d57f47055a04/bin/examples/custom_compiler/ngc_/ngc.runfiles/_main/examples/node_modules/.aspect_rules_js/@angular+compiler-cli@19.0.0-next.2_1463032538/node_modules/@angular/compiler-cli/bundles/chunk-LYN2P66H.js:1093:11)
    at verifySupportedTypeScriptVersion (file:///mnt/ephemeral/output/rules_ts/e2e_test/sandbox/linux-sandbox/839/execroot/_main/bazel-out/k8-opt-exec-ST-d57f47055a04/bin/examples/custom_compiler/ngc_/ngc.runfiles/_main/examples/node_modules/.aspect_rules_js/@angular+compiler-cli@19.0.0-next.2_1463032538/node_modules/@angular/compiler-cli/bundles/chunk-LYN2P66H.js:1097:3)
    at new NgtscProgram (file:///mnt/ephemeral/output/rules_ts/e2e_test/sandbox/linux-sandbox/839/execroot/_main/bazel-out/k8-opt-exec-ST-d57f47055a04/bin/examples/custom_compiler/ngc_/ngc.runfiles/_main/examples/node_modules/.aspect_rules_js/@angular+compiler-cli@19.0.0-next.2_1463032538/node_modules/@angular/compiler-cli/bundles/chunk-LYN2P66H.js:4277:7)
    at createProgram (file:///mnt/ephemeral/output/rules_ts/e2e_test/sandbox/linux-sandbox/839/execroot/_main/bazel-out/k8-opt-exec-ST-d57f47055a04/bin/examples/custom_compiler/ngc_/ngc.runfiles/_main/examples/node_modules/.aspect_rules_js/@angular+compiler-cli@19.0.0-next.2_1463032538/node_modules/@angular/compiler-cli/bundles/chunk-LYN2P66H.js:4498:10)
    at performCompilation (file:///mnt/ephemeral/output/rules_ts/e2e_test/sandbox/linux-sandbox/839/execroot/_main/bazel-out/k8-opt-exec-ST-d57f47055a04/bin/examples/custom_compiler/ngc_/ngc.runfiles/_main/examples/node_modules/.aspect_rules_js/@angular+compiler-cli@19.0.0-next.2_1463032538/node_modules/@angular/compiler-cli/bundles/chu

... 1201 chars truncated

💡 To reproduce the build failures, run

bazel build --output_groups=+types //ts/test:_ts_proto_library_with_dep_protoc //examples/custom_compiler:angular

Bazel-8

e2e/test

⚠️ Buildkite build #445 failed.

//examples/custom_compiler:angular failed to build

ngc failed: error executing TsProject command (from target //examples/custom_compiler:angular) bazel-out/k8-opt-exec-ST-d57f47055a04/bin/examples/custom_compiler/ngc_/ngc --project examples/custom_compiler/tsconfig.json --rootDir examples/custom_compiler --declaration false
 
Use --sandbox_debug to see verbose messages from the sandbox and retain the sandbox build root for debugging
 
error TS500: Error: The Angular Compiler requires TypeScript >=5.4.0 and <5.7.0 but 5.7.3 was found instead.
    at checkVersion (file:///mnt/ephemeral/output/rules_ts/e2e_test/sandbox/linux-sandbox/688/execroot/_main/bazel-out/k8-opt-exec-ST-d57f47055a04/bin/examples/custom_compiler/ngc_/ngc.runfiles/_main/examples/node_modules/.aspect_rules_js/@angular+compiler-cli@19.0.0-next.2_1463032538/node_modules/@angular/compiler-cli/bundles/chunk-LYN2P66H.js:1093:11)
    at verifySupportedTypeScriptVersion (file:///mnt/ephemeral/output/rules_ts/e2e_test/sandbox/linux-sandbox/688/execroot/_main/bazel-out/k8-opt-exec-ST-d57f47055a04/bin/examples/custom_compiler/ngc_/ngc.runfiles/_main/examples/node_modules/.aspect_rules_js/@angular+compiler-cli@19.0.0-next.2_1463032538/node_modules/@angular/compiler-cli/bundles/chunk-LYN2P66H.js:1097:3)
    at new NgtscProgram (file:///mnt/ephemeral/output/rules_ts/e2e_test/sandbox/linux-sandbox/688/execroot/_main/bazel-out/k8-opt-exec-ST-d57f47055a04/bin/examples/custom_compiler/ngc_/ngc.runfiles/_main/examples/node_modules/.aspect_rules_js/@angular+compiler-cli@19.0.0-next.2_1463032538/node_modules/@angular/compiler-cli/bundles/chunk-LYN2P66H.js:4277:7)
    at createProgram (file:///mnt/ephemeral/output/rules_ts/e2e_test/sandbox/linux-sandbox/688/execroot/_main/bazel-out/k8-opt-exec-ST-d57f47055a04/bin/examples/custom_compiler/ngc_/ngc.runfiles/_main/examples/node_modules/.aspect_rules_js/@angular+compiler-cli@19.0.0-next.2_1463032538/node_modules/@angular/compiler-cli/bundles/chunk-LYN2P66H.js:4498:10)
    at performCompilation (file:///mnt/ephemeral/output/rules_ts/e2e_test/sandbox/linux-sandbox/688/execroot/_main/bazel-out/k8-opt-exec-ST-d57f47055a04/bin/examples/custom_compiler/ngc_/ngc.runfiles/_main/examples/node_modules/.aspect_rules_js/@angular+compiler-cli@19.0.0-next.2_1463032538/node_modules/@angular/compiler-cli/bundles/chu

... 1201 chars truncated

//ts/test:_ts_proto_library_with_dep_protoc failed to build

not all outputs were created or valid

💡 To reproduce the build failures, run

bazel build --output_groups=+types //examples/custom_compiler:angular //ts/test:_ts_proto_library_with_dep_protoc

Bazel-6

e2e/worker

⚠️ Buildkite build #445 failed.

@aspect_rules_ts~override~ext~npm_typescript//:copy_validator failed to build

bash failed: error executing command (from target @aspect_rules_ts~override~ext~npm_typescript//:copy_validator) /bin/bash -c 'cp -f "$1" "$2"' '' external/aspect_rules_ts~override/ts/private/ts_project_options_validator.cjs ... (remaining 1 argument skipped)
 
Use --sandbox_debug to see verbose messages from the sandbox and retain the sandbox build root for debugging
 
src/main/tools/linux-sandbox-pid1.cc:315: "mount(/mnt/ephemeral/output/rules_ts/e2e_worker/sandbox/linux-sandbox/3/_tmp, /tmp, nullptr, MS_BIND, nullptr)": No such file or directory

💡 To reproduce the build failures, run

bazel build @aspect_rules_ts~override~ext~npm_typescript//:copy_validator

Bazel-7

e2e/worker

All tests were cache hits

6 tests (100.0%) were fully cached saving 287ms.


Bazel-8

e2e/worker

All tests were cache hits

6 tests (100.0%) were fully cached saving 363ms.


Buildifier      Format

@alexeagle alexeagle changed the title another repro #476 fix(ts_proto_library): don't path .js/.d.ts emit following _virtual_imports Dec 18, 2025
@alexeagle alexeagle requested a review from jbedard December 18, 2025 19:44
outs.append(ctx.actions.declare_file("{}-{}_connectquery{}".format(prefix, service, ext), sibling = src))
outs.append(ctx.actions.declare_file(
"{}-{}_connectquery{}".format(prefix, service, ext),
# sibling = src
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete?

@jbedard
Copy link
Copy Markdown
Member

jbedard commented Dec 19, 2025

Some tests are failing still?

@alexeagle
Copy link
Copy Markdown
Contributor Author

Okay I think this doesn't work, yet...

A depends on B(strip_import_prefix="original/path/to")

B now gets written to /original/path/to/b.d.ts
the descriptor for B declares its name as /b.descriptorpb

but the typings for A are generated from the descriptor so a.d.ts writes import from ../b.js which doesn't work.

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Jan 23, 2026

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Alex Eagle seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: ts_proto_library does not work with import_prefix and strip_import_prefix in proto_library

3 participants