Open
Conversation
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
|
alexeagle
added a commit
to aspect-build/rules_js
that referenced
this pull request
Feb 11, 2026
Design: - user expected to register a toolchain providing their protoc plugin for gen-es - Adapt ProtoInfo to JsInfo so a proto_library target can appear anywhere a js_library does Example of use currently in aspect-build/rules_ts#894
alexeagle
changed the title
jbedard
reviewed
Feb 11, 2026
jbedard
reviewed
Feb 11, 2026
|
|
||
| catalog: | ||
| '@bufbuild/protobuf': '2.7.0' | ||
| '@types/node': '24' |
Contributor
Author
There was a problem hiding this comment.
newer bufbuild produces typings that don't work with older @node/types. Could downgrade protoc-gen-es instead though
Member
There was a problem hiding this comment.
this is fine in the examples repo 🤷
alexeagle
added a commit
to aspect-build/rules_js
that referenced
this pull request
Feb 11, 2026
Design: - user expected to register a toolchain providing their protoc plugin for gen-es - use an aspect to adapt `ProtoInfo` to `JsInfo`, so a proto_library target can appear anywhere a js_library does - no need for `js_proto_library` targets to pollute the package where the proto_library appears - similar to bazel-contrib/rules_ruby#292 Example of use currently in aspect-build/rules_ts#894 TODO: - for typescript, place .d.ts files in the source tree, with @kormide using diff.bzl as a validation action. Maybe this belongs in rules_ts - support connect_query - we didn't have any test/example usage of it
alexeagle
force-pushed
the
redo_proto
branch
from
3ea16b0 to
e460c33
Compare
|
Alex Eagle seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If this works, we can delete ts_proto_library from this repo, is it's no longer used.
Note, it was marked EXPERIMENTAL so technically, we could remove it before 4.0