Skip to content

DOC: fix note boxes in euclid docs#3566

Merged
bsipocz merged 2 commits intoastropy:mainfrom
bsipocz:DOC_fix_note_boxes
Apr 9, 2026
Merged

DOC: fix note boxes in euclid docs#3566
bsipocz merged 2 commits intoastropy:mainfrom
bsipocz:DOC_fix_note_boxes

Conversation

@bsipocz
Copy link
Copy Markdown
Member

@bsipocz bsipocz commented Mar 23, 2026

This is the follow-up I mentioned in #3558

cc @cosmoJFH

The second commit about switching the order or the comments and directive is a must, it was an oversight in my review that all those example code blocks got disappeared in the previous PR. If you are happy with note boxes this PR adds then the fix can piggy back with this PR, if not then I'll move those changes to a separate one.

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.10%. Comparing base (ba9f66e) to head (c9e0c99).
⚠️ Report is 28 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3566      +/-   ##
==========================================
- Coverage   73.16%   73.10%   -0.07%     
==========================================
  Files         226      224       -2     
  Lines       20918    20839      -79     
==========================================
- Hits        15305    15234      -71     
+ Misses       5613     5605       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bsipocz bsipocz force-pushed the DOC_fix_note_boxes branch from 5007747 to c9e0c99 Compare April 6, 2026 21:10
@bsipocz
Copy link
Copy Markdown
Member Author

bsipocz commented Apr 6, 2026

cc @jespinosaar @cosmoJFH - this should fix the boxes in the euclid docs as well fixing a bug that I missed in a code review and resulted in code block examples disappearing from the docs.

@cosmoJFH
Copy link
Copy Markdown
Contributor

cosmoJFH commented Apr 9, 2026

cc @jespinosaar @cosmoJFH - this should fix the boxes in the euclid docs as well fixing a bug that I missed in a code review and resulted in code block examples disappearing from the docs.

It looks ok for me. I'll ask the Euclid team before accepting the PR.

Copy link
Copy Markdown
Contributor

@cosmoJFH cosmoJFH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After looking over the changes, the Euclid team agrees to merge them.

@bsipocz bsipocz merged commit 40cdfb4 into astropy:main Apr 9, 2026
11 checks passed
@bsipocz bsipocz deleted the DOC_fix_note_boxes branch April 9, 2026 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants