DOC: fix note boxes in euclid docs#3566
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3566 +/- ##
==========================================
- Coverage 73.16% 73.10% -0.07%
==========================================
Files 226 224 -2
Lines 20918 20839 -79
==========================================
- Hits 15305 15234 -71
+ Misses 5613 5605 -8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
5007747 to
c9e0c99
Compare
|
cc @jespinosaar @cosmoJFH - this should fix the boxes in the euclid docs as well fixing a bug that I missed in a code review and resulted in code block examples disappearing from the docs. |
It looks ok for me. I'll ask the Euclid team before accepting the PR. |
cosmoJFH
left a comment
There was a problem hiding this comment.
After looking over the changes, the Euclid team agrees to merge them.
This is the follow-up I mentioned in #3558
cc @cosmoJFH
The second commit about switching the order or the comments and directive is a must, it was an oversight in my review that all those example code blocks got disappeared in the previous PR. If you are happy with note boxes this PR adds then the fix can piggy back with this PR, if not then I'll move those changes to a separate one.