Skip to content

Update the observation date modeling that has been changed during the#726

Open
lmichel wants to merge 8 commits intoastropy:mainfrom
lmichel:fix-mango-obsdate
Open

Update the observation date modeling that has been changed during the#726
lmichel wants to merge 8 commits intoastropy:mainfrom
lmichel:fix-mango-obsdate

Conversation

@lmichel
Copy link
Copy Markdown
Contributor

@lmichel lmichel commented Feb 4, 2026

During the MANGO REC process, it has been suggested to simplify the representation of the observation dates (mango:EpochPostion.obsDate).
The mango:ObsDate complex type has been replaced with a simple attribute where the representation is given by its dmtype (<ATTRIBUTE dmrole="mango:EpochPosition.obsDate" dmtype="year" value="2000.0" \>).

This change requires the SkyCoord builder to be updated as well as the annotation builder.

MANGO REC process. This is now a simple attribute instead of a complex
object.
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.59%. Comparing base (f14fabb) to head (9522514).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #726      +/-   ##
==========================================
+ Coverage   79.54%   79.59%   +0.04%     
==========================================
  Files          91       91              
  Lines       10293    10294       +1     
==========================================
+ Hits         8188     8193       +5     
+ Misses       2105     2101       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bsipocz bsipocz added this to the v1.9 milestone Feb 4, 2026
@lmichel
Copy link
Copy Markdown
Contributor Author

lmichel commented Feb 28, 2026

After the last comments in the MANGO data model RFC suggesting changes in the the observation date representation, this PR must be delayed until the new code support the final time representation in the model.

@bsipocz
Copy link
Copy Markdown
Member

bsipocz commented Mar 1, 2026

After the last comments in the MANGO data model RFC suggesting changes in the the observation date representation, this PR must be delayed until the new code support the final time representation in the model.

I'm changing it to a draft PR then, feel free to mark it back "ready for review" once it can be reviewed.

@bsipocz bsipocz marked this pull request as draft March 1, 2026 21:54
lmichel added 2 commits April 17, 2026 10:20
  as modeled in the final version of the MANGO data model (DecimalYear,
  BesselianEpoch, JulianEpoch, mjd, jd, iso)
@lmichel lmichel marked this pull request as ready for review April 17, 2026 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants