fix: add timeout to registryValidation to prevent CLI hang (#2027)#2062
Closed
justintadair-debug wants to merge 2 commits intoasyncapi:masterfrom
Closed
fix: add timeout to registryValidation to prevent CLI hang (#2027)#2062justintadair-debug wants to merge 2 commits intoasyncapi:masterfrom
justintadair-debug wants to merge 2 commits intoasyncapi:masterfrom
Conversation
…2027) When --registry-url points to an unreachable URL (e.g., firewall drops packets), the CLI hangs indefinitely because fetch() has no timeout. This fix: - Adds AbortController with 5-second timeout - Changes GET to HEAD for lighter validation - Preserves original error message for debugging - Adds specific timeout error message Fixes asyncapi#2027
justintadair-debug
requested review from
AayushSaini101,
Amzani,
Shurtu-gal,
Souvikns and
asyncapi-bot-eve
as code owners
🦋 Changeset detectedLatest commit: 87dec03 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When
--registry-urlpoints to an unreachable URL (e.g., firewall drops packets), the CLI hangs indefinitely becausefetch()has no timeout.Changes
AbortControllerwith 5-second timeoutGETtoHEADfor lighter validation (no body transfer needed)Before
asyncapi generate fromTemplate spec.yaml @asyncapi/html-template --registry-url http://unreachable:9999 # CLI hangs foreverAfter
asyncapi generate fromTemplate spec.yaml @asyncapi/html-template --registry-url http://unreachable:9999 # Error: Registry URL timed out after 5 seconds: http://unreachable:9999Fixes #2027
/attempt #2027