fix: suppress anonymous metrics submission after fatal generation errors

[chengyixu]

Summary

Fixes #2010 — When a fatal generation error occurs (e.g. non-empty output directory), the CLI attempted to flush anonymous metrics and printed an unrelated error to stdout:

Generator Error: "./out" is not an empty directory. You might override your work.
Skipping submitting anonymous metrics due to the following error: TypeError: fetch failed

The second line is confusing — it looks like a second failure but it's just a metrics network call that failed during the error path.

Root Cause

finally() in base.ts is always called by oclif, even after fatal errors. It unconditionally called recordActionFinished(), which tried to flush metrics to the network. When that network call failed (e.g. in CI or offline), the error was caught and printed to stdout, polluting the user-facing error output.

Fix

Skip metrics submission entirely when error is defined (i.e. the command exits with a fatal error):

// Skip metrics on fatal errors to avoid printing unrelated network errors. #2010
if (error !== undefined) {
  return;
}

This is correct behaviour — the metricsMetadata['success'] is still set to false before the early return (for consistency), but no network call is made.

Changes

• src/apps/cli/internal/base.ts: Guard recordActionFinished() with an early return when error is defined

Test Plan

• Existing tests pass (no regressions)
• Manual: asyncapi generate asyncapi.yaml @asyncapi/html-template --output ./non-empty-dir no longer prints the metrics error message

🤖 Generated with Claude Code

[changeset-bot]

🦋 Changeset detected

Latest commit: f29f0c6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@asyncapi/cli	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[chengyixu]

Hi @asyncapi/cli-maintainers! All CI checks are passing for this PR. Happy to make any adjustments needed for merge. Thanks!