Skip to content

Sync Python SDK models from atlanhq/models#896

Open
atlan-ci wants to merge 1 commit intomainfrom
sync-models-20260414-115833
Open

Sync Python SDK models from atlanhq/models#896
atlan-ci wants to merge 1 commit intomainfrom
sync-models-20260414-115833

Conversation

@atlan-ci
Copy link
Copy Markdown
Collaborator

Summary

This PR syncs the generated Python SDK models from the atlanhq/models repository.

Changes

Auto-generated Python model files from Pkl type definitions.

Test Plan

  • Verify generated models are syntactically correct
  • Run existing tests against updated models

🤖 This PR was automatically created by the sync-python-sdk workflow.

Source commit: 4afb2fb19d4cd80304d155848366f3e3b5075f79
Source ref: refs/heads/master

Co-Authored-By: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@claude
Copy link
Copy Markdown

claude bot commented Apr 14, 2026

Code Review Summary

This auto-generated PR syncs 455 model files from atlanhq/models. After analysis:

Issues Requiring Attention

1. Test Failures (2)

  • tests/integration/test_oauth_client.py - failing
  • tests/integration/purpose_test.py - failing

These should be investigated before merging.

2. requirements.txt Cleared
The PR empties the entire requirements.txt lockfile (274 lines deleted). This appears unintentional for a model sync and may affect build reproducibility.

3. Type Annotation Change
Collection fields changed from Set[str] to List[str] across all models. This is a potential breaking change for code relying on set semantics.

Security Review

No security concerns - model code only, no API keys/secrets, TLS config, or URL validation changes.

Key Changes

  • 455 files in pyatlan_v9/model/assets/
  • Added relationship attributes to asset classes
  • Refactored serialization with RelationshipAttributes classes
  • Renamed: function_secrets to sql_secrets

Review by Claude Code

policies: Union[list[AuthPolicy], None, UnsetType] = UNSET
"""TBC"""

deny_asset_filters: Union[List[str], None, UnsetType] = UNSET
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: Type annotations for collection fields have changed from Set[str] to List[str] throughout the models. This is a potential breaking change if consumers rely on set semantics (automatic deduplication, O(1) membership testing).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant