Skip to content

Sync Python SDK models from atlanhq/models#897

Open
atlan-ci wants to merge 1 commit intomainfrom
sync-models-20260414-190333
Open

Sync Python SDK models from atlanhq/models#897
atlan-ci wants to merge 1 commit intomainfrom
sync-models-20260414-190333

Conversation

@atlan-ci
Copy link
Copy Markdown
Collaborator

Summary

This PR syncs the generated Python SDK models from the atlanhq/models repository.

Changes

Auto-generated Python model files from Pkl type definitions.

Test Plan

  • Verify generated models are syntactically correct
  • Run existing tests against updated models

🤖 This PR was automatically created by the sync-python-sdk workflow.

Source commit: e69a2162086db388deca7e0e524506ad6a254935
Source ref: refs/heads/master

Co-Authored-By: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Comment thread requirements.txt
@@ -1,274 +0,0 @@
# This file was autogenerated by uv via the following command:
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Critical: This file is being entirely deleted (274 lines removed). The requirements.txt was a uv-generated lock file used for reproducible installs.

This deletion appears unintentional for a model sync PR. Please verify whether this was intentional or if the sync workflow accidentally emptied this file.

If intentional, add a note to the PR description explaining why.


from __future__ import annotations

from typing import Dict, List, Set, Union
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linting Error (F401): Dict, List, and Set are imported but unused. This causes CI to fail.

This needs to be fixed in the upstream code generator (atlanhq/models PythonMsgspecRenderer.pkl).


from typing import Dict, List, Set, Union

import msgspec
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linting Error (F401): The msgspec module is imported but unused. Only specific members (UNSET, UnsetType) should be imported from it.


from __future__ import annotations

from typing import Dict, List, Set, Union
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linting Error (F401): All imports from typing (Dict, List, Set, Union) are unused in this file.

The code generator is emitting a standard import block even when types aren't needed.


from typing import Dict, List, Set, Union

import msgspec
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linting Error (F401): Both msgspec (line 16) and UNSET, UnsetType (line 17) are imported but unused.

The *_related.py files that have no custom attributes don't need these imports.

@claude
Copy link
Copy Markdown

claude bot commented Apr 14, 2026

Code Review Summary

Overview

Auto-generated model sync from atlanhq/models@e69a216 introducing new Agentic, Artifact, Context, and Skill asset types.

Metric Value
Files Changed 472
New Files 17
Additions 11,022
Deletions 35,292

CI Status: ❌ Failing

Check Status Notes
ruff-lint 44 unused import errors (F401)
mypy No type errors
Trivy Setup failure (not security-related)

Issues Found

🔴 Critical: Linting Failures (Blocks Merge)

The code generator produces unused imports in *_related.py files:

  • skill_related.py: Unused Dict, List, Set, msgspec
  • skill_artifact_related.py: All imports unused (Dict, List, Set, Union, msgspec, UNSET, UnsetType)

Fix: Update PythonMsgspecRenderer.pkl in atlanhq/models to conditionally emit imports only when used.

🔴 Critical: Unintended requirements.txt Deletion

The 274-line uv-generated lock file is being deleted. This appears unintentional for a model sync PR.

Action needed: Confirm if this deletion is intentional. If not, exclude requirements.txt from the sync workflow.

Security Review ✅

Per CLAUDE.md guidelines:

  • No api_key or token logging
  • No verify=False in httpx transport
  • No proxy credential exposure
  • Model files contain only type definitions (no client code)

New Asset Types Added

  1. Agentic - Base class for AI agent building blocks
  2. Artifact - Base class for artifacts
  3. Context - Context repositories for NL2SQL
  4. Skill - Reusable skills consumed by agents
  5. SkillArtifact - Artifacts associated with skills

Recommendation

Do not merge until:

  1. Fix unused imports in the code generator (atlanhq/models)
  2. Clarify the requirements.txt deletion
  3. Re-run CI after fixes

Review generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant