This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Restore ability to bind dead keys such as alt-u on macOS#186
Merged
nathansobo merged 1 commit intomasterfrom Nov 21, 2016
Merged
Restore ability to bind dead keys such as alt-u on macOS#186nathansobo merged 1 commit intomasterfrom
nathansobo merged 1 commit intomasterfrom
Conversation
A previous fix for IME input bails out of keystroke handling if the legacy keyCode property is 229. Unfortunately, this is also the value of keyCode for keystrokes like alt-u, which don’t pop up the IME menu. These keystrokes should be handled normally. It seems like the best way to distinguish these keys from the IME case is that their key value is ‘Dead’.
nathansobo
pushed a commit
that referenced
this pull request
Nov 21, 2016
Restore ability to bind dead keys such as alt-u on macOS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In a previous fix for IME in #178, we bail out of keystroke handling if the legacy
keyCodeproperty is229. Unfortunately, this is also the value ofkeyCodefor keystrokes likealt-u, which don’t pop up the IME menu. These keystrokes can and should be handled normally. It seems like the best way to distinguish these keys from the IME case is that their key value is ‘Dead’.