Conversation
tbruyelle
requested review from
giuliostramondo,
giunatale and
jaekwon
as code owners
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| import ( | ||
| "bytes" | ||
| "reflect" |
Check notice
Code scanning / CodeQL
Sensitive package import Note
Co-authored-by: “Clockwork” <alex@clockwork.gr>
Change waiting time from 15 to 20s. Given that voting peruid is set to 15s, waiting 15s might be too short depending on what happened before that call. The reason why this is triggered in that PR is unknown though.
tbruyelle
force-pushed
the
feat/gno-lc
branch
from
faffe64 to
41c1a71
Compare
Also fix wrong usage of Eventually (currentHeight is not updated according to inline func exection because it is interpreted earlier)
Collaborator
|
E2E relayer tests using this branch passing here: |
Pantani
reviewed
Mar 24, 2026
Pantani
reviewed
Mar 31, 2026
Pantani
reviewed
Apr 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a Gno light client as a cosmos module for AtomOne.
Gno uses a slightly different version of tendermint than usual cosmos chains, so this light client module is essentially a modified version of
07-tendermintlight client with updated types.Revamp of #232 with a smaller fix of proto-gen (basically downgrading the docker image from 17 to 15.2) and w/o the main merge.
Reviewers can only check the difference with the legacy Tendermint light client (
07-tendermint):# assuming this repo and github.com/cosmos/ibc-go are in the same directory: diff -bur atomone/modules/10-gno/ ibc-go/modules/light-clients/07-tendermint/