CI: Expand crypto tests - fix badarg signature#2080
Merged
bettio merged 1 commit intoatomvm:mainfrom Jan 30, 2026
Merged
Conversation
bettio
approved these changes
Jan 29, 2026
bettio
requested changes
Jan 29, 2026
Collaborator
bettio
left a comment
bettio
left a comment
There was a problem hiding this comment.
For now let's do OTP version checking, and execute them only on OTP >= 24.
petermm
force-pushed
the
ci-add-more-crypto-tests
branch
from
7b4fc8a to
a4283c4
Compare
This is in preparation of mbedtls4 - the standard crypto tests were a bit limited (compared to the esp32 ones). Sync tests/erlang_tests/test_crypto.erl with the more comprehensive ESP32 test suite. Fix and align the error return from calling crypto_one_time with badargs to match otp24+ behaviour. Signed-off-by: Peter M <petermm@gmail.com>
petermm
force-pushed
the
ci-add-more-crypto-tests
branch
from
a4283c4 to
9c8fa33
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is in preparation of mbedtls4 - the standard
crypto tests were a bit limited
(compared to the esp32 ones).
Sync tests/erlang_tests/test_crypto.erl with the
more comprehensive ESP32 test suite.
Fix and align the error return from calling crypto_one_time with badargs to match otp24+ behaviour. Fails BEAM otp<24 - so guarded the relevant tests..
These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).
SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later