Add a new CodeQL query to check free of structures#2097
Merged
bettio merged 1 commit intoatomvm:mainfrom Feb 13, 2026
Merged
Conversation
Some structures in the code are never malloc'd or calloc'd because they are abstract types (struct ListHead or struct Monitor). Add a new CodeQL query to report and detect them. Fix correct (because of alignment) but dangerous cases with temporary variable that holds the allocated structure and that are likely to be optimized out by compiler. Also fix two bugs where resource pointers were freed in error paths while they shouldn't have. Signed-off-by: Paul Guyot <pguyot@kallisys.net>
bettio
approved these changes
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some structures in the code are never malloc'd or calloc'd because they are abstract types (struct ListHead or struct Monitor). Add a new CodeQL query to report and detect them. Fix correct (because of alignment) but dangerous cases with temporary variable that holds the allocated structure and that are likely to be optimized out by compiler. Also fix two bugs where resource pointers were freed in error paths while they shouldn't have.
These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).
SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later