Add CodeQL query to check for allocations not preceeded by ensure_free#2104
Draft
pguyot wants to merge 2 commits intoatomvm:mainfrom
Draft
Add CodeQL query to check for allocations not preceeded by ensure_free#2104pguyot wants to merge 2 commits intoatomvm:mainfrom
pguyot wants to merge 2 commits intoatomvm:mainfrom
Conversation
The query also checks redundant ensure_free calls, i.e. calls followed by another call with no allocation in between. Fix errors found by the query: - Fix an insufficient ensure_free in `enif_make_resource_binary` - Added a missing ensure_free in esp32 `dac_driver.c` - Remove nine redundant ensure_free calls followed by `enif_make_resource` in `otp_ssl.c` and `otp_socket.c` and esp32 drivers - Remove a redundant ensure_free call in `nif_erlang_fun_to_list` Signed-off-by: Paul Guyot <pguyot@kallisys.net>
Fix several cases where this happened in nifs. Also add a NOLINT comment for cases where the query is not smart enough to remove the couple of false positives. Signed-off-by: Paul Guyot <pguyot@kallisys.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuation of
Fix several cases where this happened in nifs. Also add a NOLINT comment
for cases where the query is not smart enough to remove the couple of
false positives.
These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).
SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later