Introduce filtering of modules with --arch and --platform arguments#43
Open
pguyot wants to merge 1 commit intoatomvm:masterfrom
Open
Introduce filtering of modules with --arch and --platform arguments#43pguyot wants to merge 1 commit intoatomvm:masterfrom
pguyot wants to merge 1 commit intoatomvm:masterfrom
Conversation
UncleGrumpy
requested changes
Oct 11, 2025
554019b to
1c3241a
Compare
Collaborator
|
I didn’t think of it in my first review, but we should add a test to test/test_packbeam.erl to verify than other arches are filtered from the created avm, mostly for the purpose of catching any future breakage. |
Signed-off-by: Paul Guyot <pguyot@kallisys.net>
1c3241a to
7ac6948
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.