Check compilation of libraries linking to other libraries via the FFI#20
Open
arossato wants to merge 6 commits intoaugustss:mainfrom
Open
Check compilation of libraries linking to other libraries via the FFI#20arossato wants to merge 6 commits intoaugustss:mainfrom
arossato wants to merge 6 commits intoaugustss:mainfrom
Conversation
Even executables may need to define the "extra-libraries" field
Otherwise pVComma will fail when library versions are specified
…k the linking flags running with -r will not call the linker
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I proposed to add this feature to mhs but @augustss suggested to add it to microcabal.
Here's my proposal.
Now linker flags may be set also for executables with the "extra-libraries" field set.
I was thinking about implementing also "pkgconfig-depends" but that would be more invasive, since, like "build-depends" it may also set version ranges and limits. Moreover I do not know, given the minimalistic nature of mcabal, if this is appropriate. There seems to be discussions about "pkgconfig-depends" and its relations with "extra-libraries" and different preferences. What do you think?