Update notification icon margin along with icon size in ALWAYS_SHOW state#242
Open
RobertZagorski wants to merge 1 commit intoaurelhubert:masterfrom
Open
Update notification icon margin along with icon size in ALWAYS_SHOW state#242RobertZagorski wants to merge 1 commit intoaurelhubert:masterfrom
RobertZagorski wants to merge 1 commit intoaurelhubert:masterfrom
Conversation
fabiozo
approved these changes
Apr 12, 2017
|
@aurelhubert Is it possible to merge this nice PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the previous state in ALWAYS_SHOW state the notification icon stays in the same position, while the item icon is changing it's size. To make notification icon more dynamic it can animate (change it's top margin) along with item icon. In the final effect it stays relatively at the same position with selected icon.