UPSTREAM PR #1338: chore: remove SD_FAST_SOFTMAX build flag#84
Open
UPSTREAM PR #1338: chore: remove SD_FAST_SOFTMAX build flag#84
Conversation
loci-dev
temporarily deployed
to
stable-diffusion-cpp-prod
GitHub Actions
Inactive
|
No meaningful performance changes were detected across 49806 analyzed functions in the following binaries: build.bin.sd-cli, build.bin.sd-server. 🔎 Full breakdown: Loci Inspector |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Source pull request: leejet/stable-diffusion.cpp#1338
As far as I can tell, the ggml repository has no references to GGML_CUDA_FAST_SOFTMAX anywhere. Looks like a leftover from a local implementation that never got merged into ggml, and somehow got propagated by unrelated PRs (introduced in #104 , removed on #131 , then restored on #150 ).