Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2527 +/- ##
==========================================
+ Coverage 90.50% 90.87% +0.37%
==========================================
Files 52 54 +2
Lines 6632 6901 +269
Branches 1380 1421 +41
==========================================
+ Hits 6002 6271 +269
Misses 619 619
Partials 11 11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds configurable instrumentation support to the SDK, enabling emitting events at various critical points of the SDK flows.
These events can be consumed using a callback.
Some use-cases for this feature:
Changes
Instrumentation infra:
These changes enable the actual instrumentation support.
instrumentation-emitter.ts:InstrumentationEmitterclass, helper methodsinstrumentation.flow.test.ts&instrumentation.test.ts: Teststypes/instrumentation.ts: Type definitionsEXAMPLES.md: DocumentationEvent call sites:
These changes add call sites to existing SDK code at important points. PII data is not sent to emitter from codebase itself, removing the need for a filteration step.
auth-client.ts: Most of the SDK flowsclient.ts: Configuration, one call siteUsage
1. Option1: Environment Variables
Option 2: Custom callback
Configure a callback in
Auth0ClientOptions:Tests
Added unit and flow tests for complete integration.