Conversation
Add sans-IO enforcement via disallowed-methods and disallowed-types in per-crate clippy.toml files. Bans std::fs, std::process::Command, dirs::*, and reqwest in domain crates. Added temporary #[allow] on allowed_signers.rs I/O calls (to be removed in fn-61.4).
Add missing fake implementations for GitConfigProvider and ArtifactSource port traits. Both follow FakeAgentProvider pattern with call recording, builder methods, and configurable failures.
…ct ports Add contract test suites that verify behavioral correctness for any implementation of GitConfigProvider, GitDiagnosticProvider, CryptoDiagnosticProvider, and ArtifactSource. Applied to all fakes.
…(fn-61.4) Remove direct std::fs usage from auths-sdk's allowed_signers workflow by introducing an AllowedSignersStore port trait. CLI callers now inject a FileAllowedSignersStore adapter, and tests use FakeAllowedSignersStore. Also fixes integration test compilation by enabling test-utils feature via self-referential dev-dependency in auths-sdk/Cargo.toml. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Remove direct std::fs usage from auths-core's config.rs by introducing a ConfigStore port trait. CLI callers now inject FileConfigStore adapter. FakeConfigStore added to auths-core testing module. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…61.6) Add RootsFile::parse() pure method for sans-IO callers. Add #[allow] annotations with INVARIANT comments on all inherently I/O-bound code: PinnedIdentityStore (file-backed adapter), EncryptedFileStorage, agent shutdown, Unix socket lifecycle, FFI boundary, test builders, and paths home-dir resolution. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…-61.7) Add clippy.toml to auths-core duplicating workspace rules plus sans-IO bans. Add #[allow] on import statements, struct fields, and test modules where the per-crate rules surface new violations. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…nt (fn-61.8) Proactively annotate all I/O-performing production functions and test modules in auths-id with #[allow(clippy::disallowed_methods)] in preparation for the per-crate clippy.toml that will enforce sans-IO architecture. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…-61.9) Adds crates/auths-id/clippy.toml with workspace rules + sans-IO bans (filesystem, process, dirs, network). Fixes disallowed_types coverage on keri/cache module. All 311 tests pass, zero clippy warnings. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…1.10) - Replace InMemoryArtifact with FakeArtifactSource::from_data() (computes real SHA-256) - Replace FailingArtifact with FakeArtifactSource::digest_fails_with()/metadata_fails_with() - Move FakeSecureSigner to auths-sdk/src/testing/fakes/signer.rs - Replace FakePassphraseProvider with PrefilledPassphraseProvider from auths-core - Document FailingKeyStorage as intentionally test-local Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Auths Commit Verification
Result: ❌ 0/10 commits verified How to fixCommit macOS: Then re-sign: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.