Skip to content

Fix set.ignore not applying for resouces parsing list of objects in Create/Update operations#660

Merged
ack-prow[bot] merged 3 commits intoaws-controllers-k8s:mainfrom
knottnt:fix-set-ignore-from-not-applied-in-non-read-methods
Feb 9, 2026
Merged

Fix set.ignore not applying for resouces parsing list of objects in Create/Update operations#660
ack-prow[bot] merged 3 commits intoaws-controllers-k8s:mainfrom
knottnt:fix-set-ignore-from-not-applied-in-non-read-methods

Conversation

@knottnt
Copy link
Copy Markdown
Contributor

@knottnt knottnt commented Feb 5, 2026

Issue #, if available:

Description of changes:

  • Add test case validating set.ignore behavior for elbv2 Create operation
  • Use passed in opType instead of hardcoding OpTypeList in setResourceReadMany()

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

- Add elbv2 test data
- Add test case for validating that set.ignore can be applied to Create method
@ack-prow ack-prow Bot requested review from a-hilaly and jlbutler February 5, 2026 00:03
@ack-prow ack-prow Bot added the approved label Feb 5, 2026
Copy link
Copy Markdown
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@a-hilaly
Copy link
Copy Markdown
Member

a-hilaly commented Feb 5, 2026

/cc @michaelhtm

@ack-prow ack-prow Bot requested a review from michaelhtm February 5, 2026 17:59
@a-hilaly
Copy link
Copy Markdown
Member

a-hilaly commented Feb 5, 2026

/retest

@ack-prow
Copy link
Copy Markdown

ack-prow Bot commented Feb 5, 2026

@knottnt: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
verify-attribution b9d5ab9 link false /test verify-attribution
s3-olm-test b9d5ab9 link false /test s3-olm-test

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@a-hilaly
Copy link
Copy Markdown
Member

a-hilaly commented Feb 5, 2026

/test ec2-controller-test

@michaelhtm
Copy link
Copy Markdown
Member

/lgtm

@ack-prow ack-prow Bot added the lgtm Indicates that a PR is ready to be merged. label Feb 9, 2026
@ack-prow
Copy link
Copy Markdown

ack-prow Bot commented Feb 9, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a-hilaly, knottnt, michaelhtm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [a-hilaly,knottnt,michaelhtm]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow Bot merged commit 4d66e16 into aws-controllers-k8s:main Feb 9, 2026
17 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants