fix(idempotency): ensure unique idempotency keys for multiple methods with same key#1124
Merged
fix(idempotency): ensure unique idempotency keys for multiple methods with same key#1124
Conversation
… with same key - Refactor BasePersistenceStore to use AsyncLocal for full function name, supporting multiple idempotent methods in the same Lambda - Add SetFullFunctionName to correctly isolate keys per method - Update key generation to use method-specific names - Add test for multiple idempotent methods with same key to verify separate records are created - Add GetAllKeys to InMemoryPersistenceStore for test/debug support
pull-request-size
bot
added
the
size/L
github-actions
bot
added
the
bug
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1124 +/- ##
===========================================
- Coverage 79.23% 79.23% -0.01%
===========================================
Files 299 299
Lines 12441 12451 +10
Branches 1490 1488 -2
===========================================
+ Hits 9858 9865 +7
- Misses 2128 2131 +3
Partials 455 455 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
Hi there I'll review this tomorrow morning |
dreamorosi
approved these changes
Jan 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: #1123
Summary
Changes
User experience
Checklist
Please leave checklist items unchecked if they do not apply to your change.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.