Updates to address feedback#1786
Merged
niallthomson merged 4 commits intoaws-samples:ja-translationfrom Mar 2, 2026
Merged
Conversation
| - Carts | ||
| - Assets | ||
|
|
||
| NEVER translate the content inside bash code blocks (blocks marked with ```bash). This includes commands, command output, inline comments (lines starting with #), and any other text within those blocks. All content inside bash code blocks must remain exactly as it appears in the English source. |
Contributor
There was a problem hiding this comment.
Did this handle fixing the log lines I see altered?
niallthomson
pushed a commit
that referenced
this pull request
Mar 3, 2026
Co-authored-by: Raj Athavale <athavr@amazon.com>
niallthomson
pushed a commit
that referenced
this pull request
Mar 5, 2026
Co-authored-by: Raj Athavale <athavr@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #1398
Quality checks
make test module="<module>"it was successful (see https://github.com/aws-samples/eks-workshop-v2/blob/main/docs/automated_tests.md)By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.