fix(cli): incorrect cdk diff output for nested stacks#1229
Merged
aws-cdk-automation merged 3 commits intomainfrom Mar 17, 2026
Merged
fix(cli): incorrect cdk diff output for nested stacks#1229aws-cdk-automation merged 3 commits intomainfrom
aws-cdk-automation merged 3 commits intomainfrom
Conversation
1 task
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1229 +/- ##
=======================================
Coverage 87.94% 87.94%
=======================================
Files 74 74
Lines 10339 10339
Branches 1377 1377
=======================================
Hits 9093 9093
Misses 1220 1220
Partials 26 26
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kaizencc
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1228
cdk diffproduces incorrect output for nested stacks when the mangled character filter triggers. The mangled diff computation informatStackDiffHelperusesthis.oldTemplate(root stack's deployed template) instead of theoldTemplateparameter (nested stack's deployed template). This causes the correct nested diff to be overwritten with a meaningless comparison between the root and nested templates.The fix replaces
this.oldTemplatewitholdTemplateon one line.Added unit test for nested stack mangled character filtering.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license