fix: hotswap is not discoverable via telemetry#1230
Open
Conversation
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1230 +/- ##
=======================================
Coverage 87.94% 87.95%
=======================================
Files 74 74
Lines 10339 10364 +25
Branches 1377 1386 +9
=======================================
+ Hits 9093 9116 +23
- Misses 1220 1222 +2
Partials 26 26
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new
HOTSWAPtelemetry event type that fires when hotswap deployments are attempted, tracking success/failure state and resource change counts. The motivation behind this is to track hotswap efficiency.For example,
{ "event": { "state": "FAILED", "eventType": "HOTSWAP", "duration": 456, "error": { "name": "UnknownError" }, "counters": { "hotswapped": 0, "hotswappableChanges": 1, "nonHotswappableChanges": 0 } } }By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license